Skip to content

config/machine: zen5 machine target on gcc 15+ #5632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2025
Merged

config/machine: zen5 machine target on gcc 15+ #5632

merged 1 commit into from
Jul 22, 2025
+41 −0

Conversation

nlgripto
Copy link
Collaborator

@nlgripto nlgripto commented Jul 11, 2025 •
edited
Loading 

nick@nick-dev1:~/firedancer$ MACHINE=linux_gcc_zen5 make -j fdctl
Using MACHINE=linux_gcc_zen5
Using EXTRAS=
"openssl not installed, skipping"
config/machine/linux_gcc_zen5.mk:21: *** Unsupported GCC version 13. Only GCC 14+ is supported for zen5..  Stop.

To which I then upgrade to gcc 14, which does not actually support -mtune=znver5

So, we support gcc 15!

@nlgripto nlgripto changed the title zen5 machine target on gcc 14+ config/machine: zen5 machine target on gcc 14+ Jul 11, 2025
@SEJeff
Copy link
Collaborator

SEJeff commented Jul 15, 2025 •
edited
Loading

To which I then upgrade to gcc 14, which does not actually support -mtune=znver5

We definitely want gcc 15 for all of the zen5 patches.

Here are some generic benchmarks using the phoronix test suite.

@nlgripto
Copy link
Collaborator Author

nlgripto commented Jul 15, 2025 •
edited
Loading

yep, havent finished updating the PR yet

@nlgripto nlgripto force-pushed the config/machine-zen5 branch 2 times, most recently from e4da880 to c7efb3c Compare July 15, 2025 17:46
@nlgripto nlgripto requested a review from ripatel-fd July 15, 2025 17:46
@nlgripto nlgripto marked this pull request as ready for review July 15, 2025 17:46
@nlgripto nlgripto force-pushed the config/machine-zen5 branch from c7efb3c to 9321ba0 Compare July 15, 2025 17:46
@nlgripto nlgripto changed the title config/machine: zen5 machine target on gcc 14+ config/machine: zen5 machine target on gcc 15+ Jul 15, 2025
SEJeff
SEJeff reviewed Jul 15, 2025
View reviewed changes
@nlgripto nlgripto requested a review from anwayde July 15, 2025 19:51
ripatel-fd
ripatel-fd requested changes Jul 16, 2025
View reviewed changes
Copy link
Contributor

@ripatel-fd ripatel-fd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@nlgripto nlgripto requested a review from ripatel-fd July 16, 2025 16:16
@nlgripto nlgripto force-pushed the config/machine-zen5 branch from 90c743c to 508dba6 Compare July 22, 2025 14:48
@ripatel-fd ripatel-fd enabled auto-merge July 22, 2025 14:51
@ripatel-fd ripatel-fd added this pull request to the merge queue Jul 22, 2025
Merged via the queue into main with commit 243d403 Jul 22, 2025
9 checks passed
@ripatel-fd ripatel-fd deleted the config/machine-zen5 branch July 22, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SEJeff SEJeff SEJeff left review comments

@ripatel-fd ripatel-fd ripatel-fd approved these changes

@anwayde anwayde Awaiting requested review from anwayde

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nlgripto @SEJeff @ripatel-fd