snapshots: send manifest #5631
Open
snapshots: send manifest #5631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cali-jumptrading
force-pushed
the
cali/snapshot-tiles-send-manifest
branch
from
a57fa8d to
30b0971
Compare
There was a problem hiding this comment.
As discussed in pm, needs this so we don't try to clone the same bank twice
/* If the bank already exists, that means that we have already
restored the bank for this slot and we can return out. */
fd_bank_t * bank = fd_banks_get_bank( slot_ctx->banks, manifest->bank.slot );
if( FD_UNLIKELY( !!bank ) ) {
FD_LOG_NOTICE(( "The bank for slot %lu already exists. Skipping manifest restore", manifest->bank.slot ));
slot_ctx->bank = bank;
return slot_ctx;
}
cali-jumptrading
force-pushed
the
cali/snapshot-tiles-send-manifest
branch
2 times, most recently
from
9e16286 to
1ab248c
Compare
cali-jumptrading
force-pushed
the
cali/snapshot-tiles-send-manifest
branch
from
1ab248c to
7bee0a3
Compare
lidatong
reviewed
Jul 14, 2025
cali-jumptrading
force-pushed
the
cali/snapshot-tiles-send-manifest
branch
7 times, most recently
from
91f3978 to
02bee6c
Compare
lidatong
previously approved these changes
Jul 14, 2025
Comment on lines
-211
to
+250
| snapshot_reset_acc_data( fd_snapshot_parser_t * parser FD_PARAM_UNUSED, | ||
| snapshot_reset_acc_data( fd_snapshot_parser_t * parser, | ||
| void * _ctx ) { | ||
| (void)parser; |
There was a problem hiding this comment.
why FD_PARAM_UNUSED to (void)?
There was a problem hiding this comment.
I just thought being consistent with using (void) was better. let me know if you disagree
cali-jumptrading
force-pushed
the
cali/snapshot-tiles-send-manifest
branch
4 times, most recently
from
2f7580b to
b364e4b
Compare
cali-jumptrading
force-pushed
the
cali/snapshot-tiles-send-manifest
branch
from
b364e4b to
6ee879d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make the snapin tile send the manifest every time it parses one.