WIP: changes to merge gossip2 branch #5154

ravyu-jump · 2025-05-16T21:50:03Z

setup type defs and fn defintions for parsing
parsers for ping and pong
progress
rx ping/pong, tx ping, ping/pong serializers, helper functions, coalesce ping and pong into one type

…sce ping and pong into one type

src/discof/gossip/fd_gossip_tile.c

mmcgee-jump · 2025-05-18T19:13:39Z

src/flamenco/gossip/fd_crds.h

@@ -2,6 +2,7 @@
 #define HEADER_fd_src_flamenco_gossip_fd_crds_h

 #include "../../util/fd_util.h"
+#include "../../util/net/fd_net_headers.h"


Not needed by the header, only add include to the .h file if the header uses it, this should be in the .c

both headers are needed here for types (fd_rng_t and fd_ip4_port_t respectively)

src/flamenco/gossip/fd_gossip.c

mmcgee-jump · 2025-05-18T19:20:04Z

src/flamenco/gossip/fd_gossip.c


 static int
 rx_prune( fd_gossip_t *             gossip,
          fd_gossip_prune_t const * prune,
          long                      now ) {
-  if( FD_UNLIKELY( now-500L*1000L*1000L>prune->data->wallclock ) ) return FD_GOSSIP_RX_ERR_PRUNE_TIMEOUT;
-  else if( FD_UNLIKELY( !memcmp( gossip->identity_pubkey, prune->data->destination, 32UL ) ) ) return FD_GOSSIP_RX_ERR_PRUNE_DESTINATION;
+  if( FD_UNLIKELY( now-500L*1000L*1000L>(long)prune->wallclock ) ) return FD_GOSSIP_RX_PRUNE_ERR_TIMEOUT;


prune wallclock should already be a long, and unitize to nanos, I'd rename wallclock_nanos

src/flamenco/gossip/fd_gossip.c

src/flamenco/gossip/fd_ping_tracker.c

src/flamenco/gossip/fd_gossip_types.h

src/flamenco/gossip/fd_gossip_msg.h

src/flamenco/gossip/fd_gossip.c

mmcgee-jump · 2025-05-18T19:43:03Z

src/flamenco/gossip/fd_gossip.c

+                                      &peer_pubkey,
+                                      &peer_address,
+                                      &ping_token ) ) {
+    fd_gossip_message_t * message = new_outgoing( gossip );


No need to construct this message, this is just additional copies, you can serialize directly from the components.

src/flamenco/gossip/fd_gossip.c

src/flamenco/gossip/fd_gossip.h

src/flamenco/gossip/fd_gossip_msg_parse.c

mmcgee-jump · 2025-05-18T19:48:40Z

src/flamenco/gossip/fd_crds_value.h

+#define FD_GOSSIP_CLIENT_FD     (2)
+#define FD_GOSSIP_CLIENT_AGAVE  (3)
+
+struct fd_gossip_contact_info {


I would namespace these,

Suggested change

struct fd_gossip_contact_info {

struct fd_gossip_message_contact_info {

src/flamenco/gossip/fd_ping_tracker.h

mmcgee-jump · 2025-05-18T19:51:30Z

src/flamenco/gossip/fd_gossip.c

+  fd_ping_tracker_hash_ping_token( ping->token, message->piong->hash );
+  gossip->sign_fn( gossip->sign_ctx, message->piong->hash, 32UL, message->piong->signature );
+
+  fd_ping_tracker_track( gossip->ping_tracker,


No need to call track here, we are just responding to someone else. Also don't do the memcpys, just serialize directly into buffer.

src/flamenco/gossip/fd_gossip_msg.h

ravyu-jump added 4 commits May 16, 2025 07:33

setup type defs and fn defintions for parsing

b22d9d7

parsers for ping and pong

9841130

progress

dfafa9b

rx ping/pong, tx ping, ping/pong serializers, helper functions, coale…

df53f71

…sce ping and pong into one type

ravyu-jump changed the title ~~WIP: gossip2 branch~~ WIP: changes to merge gossip2 branch May 16, 2025

init keyguard_client

11a23ee