Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: predefinedVariables should have the lowest precedence and discourage overriding of predefined variables #1466

Merged
merged 2 commits into from
Jan 13, 2025
Merged

fix: predefinedVariables should have the lowest precedence and discourage overriding of predefined variables #1466

merged 2 commits into from
Jan 13, 2025

Conversation

ANGkeith
Copy link
Collaborator

@ANGkeith ANGkeith commented Jan 11, 2025 •
edited
Loading

closes #1465

image

@ANGkeith ANGkeith force-pushed the fix/#1465 branch 2 times, most recently from db29df3 to e105fa8 Compare January 11, 2025 04:36
@ANGkeith ANGkeith marked this pull request as draft January 11, 2025 04:43
@ANGkeith ANGkeith marked this pull request as ready for review January 11, 2025 04:47
@ANGkeith ANGkeith requested a review from firecow January 11, 2025 04:47
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@xurizaemon xurizaemon mentioned this pull request Jan 12, 2025
Closed
firecow
firecow approved these changes Jan 13, 2025
View reviewed changes
Copy link
Owner

@firecow firecow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch., I actually thought that predefined was the most important ones already

@firecow firecow merged commit dd044e2 into master Jan 13, 2025
11 checks passed
@firecow firecow deleted the fix/#1465 branch January 13, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@firecow firecow firecow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gitlab-ci-local overwrites a pre-defined variable from gitlab-ci.yml
2 participants
@ANGkeith @firecow