Replace join-path dependency with native node:path#525
Open
Frank3K wants to merge 1 commit intofirebase:masterfrom
Open
Replace join-path dependency with native node:path#525Frank3K wants to merge 1 commit intofirebase:masterfrom
Frank3K wants to merge 1 commit intofirebase:masterfrom
Conversation
join-path was only used as a thin wrapper around path.join in both call sites. Switch to the built-in node:path module and remove the now-unnecessary dependency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
join-pathhas been unmaintained since 2017 and adds unnecessary dependency weight (pulling inurl-join,as-array, andvalid-urltransitively)src/loaders/config-file.jsandsrc/providers/fs.tsonly ever passed filesystem paths — never URLs — so the URL-handling logic injoin-pathwas dead code in this projectpath.join/import { join } from "node:path"from Node's built-in standard libraryeslint-disablecomment that was suppressing a warning caused byjoin-path's untypedrequire()node_modulesTest plan
npm testpasses with no regressions (test output identical to baseline)