-
Notifications
You must be signed in to change notification settings - Fork 253
FirebaseServerApp #366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FirebaseServerApp #366
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have changes to the client service worker, too?
@DellaBitta no changes strictly needed as the current code in |
Got it, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a few nits from the related CL, thanks James!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
auth/service-worker-sessions.js
Simplify the SW codewill do this in a follow on@ts-expect-error
when api has landedThere is no compat version of this API.
API proposal: go/fb-web-firebaseserverapp
WIP impl: firebase/firebase-js-sdk#8005
WIP docs: cl/607423524
Trying to keep it simple for now, matching the behavior of the current Admin SDK snippet in the docs—which wasn't in this repo, addressing here.
Existing snippets:
auth(-next)/server-worker-sessions.js
auth_svc_register
auth_svc_sign_in_email
auth_svc_listen_activate
auth_svc_intercept
auth_svc_subscribe
auth_svc_get_idtoken
New snippets:
auth/server-worker-sessions.js
auth_svc_admin
firebaseserverapp-next/firebaseserverapp.js
serverapp_auth