[Infra] Bump to upcoming min. supported versions #1710
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @ncooke3, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on an essential infrastructure update, raising the minimum supported deployment versions for iOS and tvOS to 15.0 across all example applications. This proactive change aligns our projects with current platform requirements, facilitating future development and ensuring compatibility with upcoming SDKs and features.
Highlights
- Minimum Deployment Target Update: I've updated the minimum iOS deployment target to 15.0 across all relevant example projects. This ensures compatibility with the latest platform features and development standards.
- tvOS Deployment Target Update: For projects supporting tvOS, I've also bumped the minimum tvOS deployment target to 15.0, maintaining consistency with the iOS updates.
- Podfile and Project Configuration Alignment: The changes include updates to both Xcode project files (
.pbxproj) and CocoaPods configuration files (Podfile) to reflect the new minimum deployment versions, ensuring build system alignment.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request consistently bumps the minimum supported iOS and tvOS deployment targets to 15.0 across various example projects and updates the template script accordingly. The changes are straightforward and align with the PR's intent of moving to upcoming minimum supported versions.
One area to double-check is the Mac Catalyst deployment target settings in config/ConfigExample.xcodeproj/project.pbxproj to ensure full compatibility with the bumped iOS SDK level for Catalyst.
It would be beneficial to add a brief summary to the PR description outlining the testing performed to confirm that all samples build and run correctly on these new minimum target versions.
Follow-up work: