Skip to content

Conversation

@ssbushi
Copy link
Contributor

@ssbushi ssbushi commented Jan 21, 2026

Undo setting cwd for processmanager. To be set only for AGY cases in the MCP server. (#4027)

Checklist (if applicable):

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @ssbushi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical regression in the end-to-end test suite. It rectifies the test execution environment for Go applications by aligning it with a recent change in genkit start's behavior, which now strictly enforces execution from the project root. The changes ensure that the Go test applications are correctly launched and located, thereby restoring the reliability of the affected tests.

Highlights

  • E2E Test Fix: This PR resolves failures in end-to-end tests that occurred due to a recent change in genkit start which now enforces running the runtime process from the detected project root.
  • Root Cause Identified: The tests were previously executing genkit start from a subdirectory (go/tests/test_app), causing go run main.go to fail because genkit start redirected the working directory to the project root (go/), making main.go inaccessible.
  • Test Configuration Updates: The test configurations in tests/src/flow_server_test.ts and tests/src/reflection_api_test.ts have been updated to run genkit start from the correct project root (../go) and to use the appropriate relative path for the Go command (go run tests/test_app/main.go).

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a failure in the end-to-end tests by updating the test execution context. The changes correctly adjust the working directory and command for genkit start, aligning with recent updates. My review includes one suggestion to improve code robustness by using a standard escape sequence in a log message.

@github-actions github-actions bot added the go label Jan 21, 2026
@ssbushi ssbushi changed the title fix(e2e): fix(e2e): Mark e2e test project root Jan 21, 2026
@ssbushi ssbushi changed the title fix(e2e): Mark e2e test project root fix(e2e): Undo ProcessManager cwd Jan 21, 2026
@ssbushi ssbushi marked this pull request as ready for review January 21, 2026 17:32
@ssbushi ssbushi enabled auto-merge (squash) January 21, 2026 18:03
@ssbushi ssbushi requested a review from pavelgj January 21, 2026 18:09
@ssbushi ssbushi merged commit 593e593 into main Jan 21, 2026
11 checks passed
@ssbushi ssbushi deleted the sb/fixe2e branch January 21, 2026 18:40
MengqinShen pushed a commit that referenced this pull request Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants