refactor(plugins/vertexai): add v2 embedder support #3496
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
docs
cabljac
force-pushed
the
@invertase/vertexai-migrate-v2-fixed
branch
from
cd7fedf to
480b59d
Compare
cabljac
force-pushed
the
@invertase/vertexai-migration-embedders
branch
from
69cac47 to
e6ae721
Compare
cabljac
commented
Sep 8, 2025
| for (const name of Object.keys(SUPPORTED_IMAGEN_MODELS)) { | ||
| actions.push(defineImagenModel(name, authClient, { projectId, location })); | ||
| } | ||
| for (const name of Object.keys(SUPPORTED_GEMINI_MODELS)) { | ||
| ======= |
There was a problem hiding this comment.
left over from a bad rebase, TODO: fix
cabljac
commented
Sep 8, 2025
| // Call the embedder action directly with a single document | ||
| const response = await embedderAction({ | ||
| input: [ | ||
| content instanceof Document ? content : new Document(content), |
There was a problem hiding this comment.
not 100% if this is passed in correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft of how to migrate embedders across to v2 in the vertexai plugin