Skip to content

revert(py/genkit): revert incorrect 3.10 asyncio compat workaround #2641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2025

Conversation

yesudeep
Copy link
Contributor

@yesudeep yesudeep commented Apr 4, 2025

CHANGELOG:

  • Reverts previous _compat.py file and usage because it is not necessary.

@yesudeep yesudeep enabled auto-merge (squash) April 4, 2025 13:07
@yesudeep yesudeep requested a review from zarinn3pal April 4, 2025 13:08
@yesudeep yesudeep force-pushed the yesudeep/fix/fix-310 branch 2 times, most recently from 3ba774e to c1db8e4 Compare April 4, 2025 13:13
@yesudeep
Copy link
Contributor Author

yesudeep commented Apr 4, 2025

Hmm.... this is strange. it works locally but not in ci... investigating.

@yesudeep yesudeep disabled auto-merge April 4, 2025 13:15
@yesudeep yesudeep marked this pull request as draft April 4, 2025 13:15
Copy link
Contributor

@zarinn3pal zarinn3pal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CHANGELOG:
- [ ] Reverts previous _compat.py file that got included
      because it is not necessary.
@yesudeep yesudeep force-pushed the yesudeep/fix/fix-310 branch from c1db8e4 to 0e2f1a6 Compare April 4, 2025 15:43
@github-actions github-actions bot added the config label Apr 4, 2025
@yesudeep yesudeep marked this pull request as ready for review April 4, 2025 15:43
@yesudeep yesudeep enabled auto-merge (squash) April 4, 2025 15:44
@yesudeep yesudeep merged commit 9e16c0d into main Apr 4, 2025
8 checks passed
@yesudeep yesudeep deleted the yesudeep/fix/fix-310 branch April 4, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants