Skip to content

feat(appcheck): appcheck recaptcha enterprise support#18261

Open
cynthiajoan wants to merge 17 commits into
mainfrom
firebaseai/appcheck_research
Open

feat(appcheck): appcheck recaptcha enterprise support#18261
cynthiajoan wants to merge 17 commits into
mainfrom
firebaseai/appcheck_research

Conversation

@cynthiajoan
Copy link
Copy Markdown
Collaborator

Description

Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@cynthiajoan cynthiajoan marked this pull request as ready for review June 3, 2026 04:42
@cynthiajoan
Copy link
Copy Markdown
Collaborator Author

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for reCAPTCHA providers across Android, iOS, and Web platforms in firebase_app_check and integrates recaptchaSiteKey into FirebaseOptions across firebase_core platforms. Key feedback includes removing mavenLocal() from build files to prevent consumer dependency issues, adhering to the repository style guide by avoiding the ! operator in _safeToDart, and exporting WebProvider to replace dynamic types with safer, strongly-typed declarations in the example app.

Comment on lines +10 to 12
mavenLocal()
google()
mavenCentral()
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Avoid adding mavenLocal() to the library's repositories as it can cause dependency resolution issues and slow down builds for consumers of the plugin. This is typically used only for local development and should be removed before merging.

    google()
    mavenCentral()

Comment on lines +18 to 20
mavenLocal()
google()
mavenCentral()
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Avoid adding mavenLocal() to the library's repositories as it can cause dependency resolution issues and slow down builds for consumers of the plugin. This is typically used only for local development and should be removed before merging.

    google()
    mavenCentral()

Comment on lines +30 to +33
String? _safeToDart(JSString? jsString) {
if (jsString.isUndefinedOrNull) return null;
return jsString!.toDart;
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

The use of the ! operator violates the repository style guide (Rule 23: "NO ! operator. Use ? and flow analysis"). We can safely promote jsString to a non-nullable type by checking jsString == null first, which allows calling toDart without the ! operator.

Suggested change
String? _safeToDart(JSString? jsString) {
if (jsString.isUndefinedOrNull) return null;
return jsString!.toDart;
}
String? _safeToDart(JSString? jsString) {
if (jsString == null || jsString.isUndefinedOrNull) return null;
return jsString.toDart;
}
References
  1. Null Safety: NO ! operator. Use ? and flow analysis (e.g. if (x != null)). (link)

Comment on lines 26 to +27
WebDebugProvider,
WebReCaptchaProvider,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Export WebProvider from the platform interface so that consumers can use it as a type in their code, ensuring consistency with other platform providers like AndroidAppCheckProvider and AppleAppCheckProvider.

Suggested change
WebDebugProvider,
WebReCaptchaProvider,
WebDebugProvider,
WebProvider,
WebReCaptchaProvider,

WindowsAppCheckProvider? windows,
}) async {
try {
dynamic providerWeb;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Since WebProvider is now exported, we can use WebProvider? instead of dynamic for providerWeb to improve type safety.

Suggested change
dynamic providerWeb;
WebProvider? providerWeb;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant