chore(deps): Unify versions into global config and update AGP version to 8.2.1 #17272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelVerdon
changed the title
russellwheatley
requested changes
Apr 17, 2025
packages/firebase_core/firebase_core/android/global-config.gradle
Outdated
Show resolved
Hide resolved
...rebase_data_connect/firebase_data_connect/example/android/app/generated_android_versions.txt
Outdated
Show resolved
Hide resolved
packages/firebase_data_connect/firebase_data_connect/example/android/app/local-config.gradle
Outdated
Show resolved
Hide resolved
Lyokone
reviewed
Apr 17, 2025
| @@ -8,7 +8,7 @@ buildscript { | |||
| } | |||
|
|
|||
| dependencies { | |||
| classpath 'com.android.tools.build:gradle:8.1.2' | |||
| classpath 'com.android.tools.build:gradle:8.2.1' | |||
There was a problem hiding this comment.
Do you think we can unify this version as well?
There was a problem hiding this comment.
I think we definitely can, happy to work on this.
MichaelVerdon
force-pushed
the
global-versions
branch
from
3b2c56f to
51f9e28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use a global configuration to make upgrading java versions more feasible.
Related Issues
Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?