Fixes failing CI tests (#428)

Upgrades tests to Node 8.
Upgrades protractor to the latest version.
Switches from phantomjs to headless chrome.
Adds various new timeout durations to decrease likelihood of failure.
Adds new criteria for test retry, though this needs more confirmation.

Author: bojeil-google

.travis.yml

@@ -1,9 +1,16 @@
 language: node_js
 node_js:
-  - '6'
+  - '8'
 install: npm install
 script: npm test -- --saucelabs
 before_install:
+  - export CHROME_BIN=/usr/bin/google-chrome
+  - export DISPLAY=:99.0
+  - sh -e /etc/init.d/xvfb start
+  - sudo apt-get update
+  - sudo apt-get install -y libappindicator1 fonts-liberation
+  - wget https://dl.google.com/linux/direct/google-chrome-stable_current_amd64.deb
+  - sudo dpkg -i google-chrome*.deb
   - unset _JAVA_OPTIONS
 addons:
   sauce_connect: true

buildtools/run_tests.sh

@@ -48,19 +48,21 @@
 # Travis will run `npm test -- --saucelabs`.
 
 cd "$(dirname $(dirname "$0"))"
+BIN_PATH="./node_modules/.bin"
+PROTRACTOR_BIN_PATH="./node_modules/protractor/bin"
 
 function killServer () {
   if [ "$seleniumStarted" = true ]; then
     echo "Stopping Selenium..."
-    ./node_modules/.bin/webdriver-manager shutdown
-    ./node_modules/.bin/webdriver-manager clean
+    $PROTRACTOR_BIN_PATH/webdriver-manager shutdown
+    $PROTRACTOR_BIN_PATH/webdriver-manager clean
   fi
   echo "Killing HTTP Server..."
   kill $serverPid
 }
 
 # Start the local webserver.
-./node_modules/.bin/gulp serve &
+$BIN_PATH/gulp serve &
 serverPid=$!
 echo "Local HTTP Server started with PID $serverPid."
 
@@ -73,16 +75,18 @@ if [[ $1 = "--saucelabs" ]]; then
   sleep 2
   echo "Using SauceLabs."
   # $2 contains the tunnelIdentifier argument if specified, otherwise is empty.
-  ./node_modules/.bin/protractor protractor.conf.js --saucelabs $2
+  $PROTRACTOR_BIN_PATH/protractor protractor.conf.js --saucelabs $2
 else
-  echo "Using PhantomJS."
+  echo "Using Headless Chrome."
   # Updates Selenium Webdriver.
-  ./node_modules/.bin/webdriver-manager update
+  echo "$PROTRACTOR_BIN_PATH/webdriver-manager update --gecko=false"
+  $PROTRACTOR_BIN_PATH/webdriver-manager update --gecko=false
   # Start Selenium Webdriver.
-  ./node_modules/.bin/webdriver-manager start &>/dev/null &
+  echo "$PROTRACTOR_BIN_PATH/webdriver-manager start &>/dev/null &"
+  $PROTRACTOR_BIN_PATH/webdriver-manager start &>/dev/null &
   seleniumStarted=true
   echo "Selenium Server started."
   # Wait for servers to come up.
   sleep 10
-  ./node_modules/.bin/protractor protractor.conf.js
+  $PROTRACTOR_BIN_PATH/protractor protractor.conf.js
 fi

package-lock.json

@@ -46,8 +46,7 @@
     "gulp-sass": "^2.3.2",
     "gulp-util": "^3.0.7",
     "material-design-lite": "^1.2.0",
-    "phantomjs-prebuilt": "^2.1.13",
-    "protractor": "^4.0.9",
+    "protractor": "^5.3.2",
     "streamqueue": "^1.1.1"
   },
   "dependencies": {

package.json

@@ -48,7 +48,7 @@ config = {
   // Jasmine options. Increase the timeout to 5min instead of the default 30s.
   jasmineNodeOpts: {
     // Default time to wait in ms before a test fails.
-    defaultTimeoutInterval: 5 * 60 * 1000
+    defaultTimeoutInterval: 20 * 60 * 1000
   }
 };
 
@@ -89,21 +89,27 @@ if (options.saucelabs) {
   }
   // Avoid going over the SauceLabs concurrency limit (5).
   config.maxSessions = 5;
+  config.allScriptsTimeout = 10 * 60 * 1000;
   // List of browsers configurations tested.
   var sauceBrowsers = require('./sauce_browsers.json');
   // Configuration for SauceLabs browsers.
   config.multiCapabilities = sauceBrowsers.map(function(browser) {
     browser['tunnel-identifier'] = options.tunnelIdentifier;
+    browser.maxDuration = 2000;
+    browser.commandTimeout = 600;
+    browser.idleTimeout = 120;
     return browser;
   });
 } else {
-  // Configuration for phantomJS.
-  config.seleniumAddress = 'http://localhost:4444/wd/hub';
-  config.capabilities = {
-    'browserName': 'phantomjs',
-    'phantomjs.binary.path': require('phantomjs-prebuilt').path,
-    'phantomjs.ghostdriver.cli.args': ['--loglevel=DEBUG']
-  };
+  // Configuration for headless chrome.
+  config.directConnect = true;
+  config.multiCapabilities = [{
+    browserName: 'chrome',
+    chromeOptions: {
+      args: [ "--headless", "--disable-gpu", "--window-size=800,600",
+              "--no-sandbox", "--disable-dev-shm-usage" ]
+    }
+  }];
 }
 
 exports.config = config;

protractor.conf.js

@@ -18,6 +18,8 @@ var TEST_SERVER = 'http://localhost:4000';
 
 var FLAKY_TEST_RETRIAL = 3;
 
+var RETRY_MESSAGE_REGEX = /(ETIMEDOUT|WebDriverError|Internal Server Error|504)/;
+
 describe('Run all Closure unit tests', function() {
   /**
    * Waits for current tests to be executed.
@@ -85,7 +87,7 @@ describe('Run all Closure unit tests', function() {
               }, function(err) {
                 // If browser test execution times out try up to trial times.
                 if (err.message &&
-                    err.message.indexOf('ETIMEDOUT') != -1 &&
+                    err.message.match(RETRY_MESSAGE_REGEX) &&
                     tries > 0) {
                   runRoutine(tries - 1, done);
                 } else {
@@ -95,8 +97,8 @@ describe('Run all Closure unit tests', function() {
             }, function(err) {
               // If browser test execution times out try up to trial times.
               if (err.message &&
-                  err.message.indexOf('ETIMEOUT') != -1 &&
-                  trial > 0) {
+                  err.message.match(RETRY_MESSAGE_REGEX) &&
+                  tries > 0) {
                 runRoutine(tries - 1, done);
               } else {
                 done.fail(err);