-
Notifications
You must be signed in to change notification settings - Fork 49
Update the Unity Hub mac installer to arm64 #1328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @a-maurice, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a critical issue in GitHub Actions workflows where Unity installations on macOS were failing. The fix involves updating the download URL for the Unity Hub installer on macOS to target the ARM64 architecture, ensuring compatibility with Apple Silicon-based runners and restoring the stability of the build process.
Highlights
- Unity Hub Installer Update: The macOS Unity Hub installer URL has been updated to specifically use the
arm64
version, resolving recent GitHub Actions failures related to Unity installation on Mac.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands on the current page.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the Unity Hub installer URL for macOS to use the arm64
version. While this may resolve issues on ARM-based runners, it's not a robust solution as it will break builds on Intel-based macOS machines. My review comment details this issue and suggests dynamically selecting the installer based on the machine's architecture for a more resilient implementation.
Description
The GitHub actions started failing to install Unity correctly on Mac, seems the likely problem is it needs to use the arm64 installer, so change it to that.
Testing
https://github.com/firebase/firebase-unity-sdk/actions/runs/17745007883
https://github.com/firebase/firebase-unity-sdk/actions/runs/17747127860
Type of Change
Place an
x
the applicable box: