Skip to content

Remove deprecated RC ConfigSettings field #1001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Remove deprecated RC ConfigSettings field #1001

merged 1 commit into from
Apr 24, 2024

Conversation

a-maurice
Copy link
Collaborator

Description

Provide details of the change, and generalize the change in the PR title above.

Remove the deprecated ConfigSettings.MinimumFetchInternalInMilliseconds in prep for the next major release, as it has been deprecated for more than a year now. Use ConfigSettings.MinimumFetchIntervalInMilliseconds instead (the difference is Internal vs Interval).


Testing

Describe how you've tested these changes.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

@a-maurice a-maurice requested a review from jonsimantov April 24, 2024 20:23
@a-maurice a-maurice merged commit aa8b056 into main Apr 24, 2024
4 checks passed
@a-maurice a-maurice deleted the am-rc_cleanup branch April 24, 2024 20:26
@firebase firebase locked and limited conversation to collaborators May 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants