Skip to content

Add sleeps after Unity calls in testapp builder #1000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

a-maurice
Copy link
Collaborator

Description

Provide details of the change, and generalize the change in the PR title above.

The testapp builder has occasionally been having issues where after one Unity call (with -quit), when it gets to the next call Unity still seems to be running, causing an error. Adding a small sleep, to give the previous call a chance to close properly.


Testing

Describe how you've tested these changes.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

@a-maurice a-maurice requested a review from cynthiajoan April 23, 2024 22:42
@a-maurice a-maurice merged commit c621a68 into main Apr 23, 2024
14 of 15 checks passed
@a-maurice a-maurice deleted the am-unity_testapp_timings branch April 23, 2024 22:45
@firebase firebase locked and limited conversation to collaborators May 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants