Skip to content

Make fields in TestDeviceSchema required #9293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Make fields in TestDeviceSchema required #9293

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f48e72d
Prefer using z.custom to type fix error
tagboola Oct 9, 2025
8941d98
Make fields in TestDeviceSchema required
tagboola Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/mcp/tools/apptesting/tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
locale: z.string(),
orientation: z.enum(["portrait", "landscape"]),
})
.required()
.describe(
`Device to run automated test on. Can run 'gcloud firebase test android|ios models list' to see available devices.`,
);
Expand Down Expand Up @@ -47,7 +48,7 @@
toAppName(appId),
new Distribution(releaseBinaryFile),
parseIntoStringArray(testCaseIds),
testDevices,

Check failure on line 51 in src/mcp/tools/apptesting/tests.ts

View workflow job for this annotation

GitHub Actions / unit (20) 

Argument of type '{ version?: string; locale?: string; model?: string; orientation?: "portrait" | "landscape"; }[]' is not assignable to parameter of type 'TestDevice[]'.

Check failure on line 51 in src/mcp/tools/apptesting/tests.ts

View workflow job for this annotation

GitHub Actions / unit (22) 

Argument of type '{ version?: string; locale?: string; model?: string; orientation?: "portrait" | "landscape"; }[]' is not assignable to parameter of type 'TestDevice[]'.

Check failure on line 51 in src/mcp/tools/apptesting/tests.ts

View workflow job for this annotation

GitHub Actions / unit (22) 

Argument of type '{ version?: string; locale?: string; model?: string; orientation?: "portrait" | "landscape"; }[]' is not assignable to parameter of type 'TestDevice[]'.
),
);
},
Expand Down
Loading