-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Update functions template to meet modern dev practices. #9287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
taeold
commented
Oct 8, 2025
- Removed the ESLint-on-init prompt; JavaScript and TypeScript setups now always scaffold a Biome config and skip adding lint steps for JS predeploys
- Refreshed both JS/TS function templates to use ESM syntax
- Consolidated template packages: renamed the “nolint” variants to the primary package.json, added type: "module"
- Bumped firebase- admin/firebase-functions to current versions.
- Modernized the TypeScript tsconfig.json (ES2022 target, ESNext modules, bundler resolution, skip lib checks)
Summary of ChangesHello @taeold, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly updates the Firebase Functions templates to align with modern JavaScript and TypeScript development standards. It transitions from ESLint to Biome for linting, adopts ESM for module management, updates Firebase SDK dependencies, and refines TypeScript compiler options. The changes streamline the initialization process by removing the ESLint prompt and consolidating template files. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request does a great job of modernizing the Firebase Functions templates by introducing Biome, adopting ESM syntax, and updating dependencies. The code is cleaner and the setup process is simpler. I've found one high-severity issue where the implementation and tests for TypeScript predeploy
hooks are inconsistent. Please see my detailed comment below.