Skip to content

Conversation

schnecle
Copy link
Contributor

@schnecle schnecle commented Oct 8, 2025

Description

  • Refactor dataconnect tools to use common appUtils
  • Increase test coverage

Scenarios Tested

  • Platform detection in /firebase:init for web, ios, android and multiple. Example output:
> /firebase:init


ℹRequest cancelled.
 

> Can you print out the prompt you just received

✦ Your goal is to help the user setup Firebase services in this workspace. Firebase is a large platform with many potential uses, so you will:

   1. Detect which Firebase services are already in use in the workspace, if any
   2. Determine which new Firebase services will help the user build their app
   3. Provision and configure the services requested by the user

  Workspace Info

  Use this information to determine which Firebase services the user is already using (if any).

  Workspace platform(s): ANDROID, IOS
  • Ran firebase init on a web application

Sample Commands

  • /firebase:init
  • firebase init

// Detect what platform based on current user
let targetPlatform = await getPlatformFromFolder(appDir);
if (targetPlatform === Platform.NONE) {
let targetPlatforms = await getPlatformsFromFolder(appDir);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maneesht is the right person to take a look at management/apps.ts~

I took a glance. Don't see any issues.

@schnecle schnecle requested a review from maneesht October 9, 2025 15:04
@schnecle schnecle force-pushed the schnecle/cleanup-dataconnect-apputils branch from b6bdceb to 79b8215 Compare October 9, 2025 19:51
@schnecle schnecle marked this pull request as ready for review October 9, 2025 19:51
@schnecle schnecle force-pushed the schnecle/cleanup-dataconnect-apputils branch from 79b8215 to 0eca209 Compare October 9, 2025 19:52
@schnecle schnecle requested a review from joehan October 9, 2025 19:55
Copy link
Contributor

@fredzqm fredzqm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

I am able to verify the FDC app detection logics still work.

@joehan
Copy link
Contributor

joehan commented Oct 9, 2025

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request does a great job of refactoring the app detection logic into a common appUtils module, which improves code organization and reusability. The increased test coverage is also a welcome addition. I've found a critical issue with a new deduplication function and a couple of other points that I've detailed in the specific comments. Once these are addressed, this will be a solid improvement.

@schnecle schnecle merged commit b2a998d into master Oct 10, 2025
48 checks passed
@schnecle schnecle deleted the schnecle/cleanup-dataconnect-apputils branch October 10, 2025 18:12
@github-project-automation github-project-automation bot moved this from Approved [PR] to Done in [Cloud] Extensions + Functions Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants