Skip to content

Conversation

fredzqm
Copy link
Contributor

@fredzqm fredzqm commented Oct 8, 2025

Instead of directly asking for an app description to generate a schema with Gemini, this change first asks the user to confirm if they want to use Gemini.

If the user confirms, it then prompts for the app description with a default value of "an app for ${setup.projectId}".

Default flow use template (enter through)

Screenshot 2025-10-08 at 9 45 31 AM

Use Gemini

Screenshot 2025-10-08 at 12 16 02 PM Screenshot 2025-10-08 at 12 18 44 PM

Instead of directly asking for an app description to generate a schema with Gemini, this change first asks the user to confirm if they want to use Gemini.

If the user confirms, it then prompts for the app description with a default value of "an app for ${setup.projectId}".
Copy link
Contributor

Summary of Changes

Hello @fredzqm, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This PR enhances the user experience for DataConnect's Gemini schema generation by adding an explicit confirmation prompt. Users will now be asked if they want to use Gemini before providing an app description, and a default app description based on the project ID is provided for convenience.

Highlights

  • Intent: This pull request introduces a confirmation step before initiating Gemini schema generation for DataConnect. Previously, the system would directly prompt for an app description; now, it first asks the user if they wish to use Gemini for schema generation.
  • Key Changes: A new confirm prompt has been added in src/init/features/dataconnect/index.ts asking 'Do you want to generate a schema with Gemini?' with a default answer of true. The subsequent prompt for the app description, used for Gemini schema generation, is now conditional on the user confirming this step. Additionally, the app description input now includes a default value of an app for ${setup.projectId}.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a confirmation step before prompting the user for an app description to generate a schema with Gemini. This change enhances the user experience by providing an opportunity to opt-in to Gemini schema generation. The review focuses on ensuring the new logic is correctly implemented and the user flow is intuitive.

@fredzqm fredzqm changed the title feat(dataconnect): add confirmation for Gemini schema generation feat(dataconnect): Add confirmation for Gemini schema generation Oct 8, 2025
@fredzqm fredzqm requested a review from yuchenshi October 8, 2025 16:59
const choices = await locationChoices(setup);
info.locationId = await select<string>({
message: "What location should the new Cloud SQL instance be in?",
message: "What location would you like to use?",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to revert it because we ask this even when CSQL isn't being provisioned.

@fredzqm fredzqm requested a review from joehan October 8, 2025 19:24
@fredzqm
Copy link
Contributor Author

fredzqm commented Oct 10, 2025

@joehan Can you take a look? Thanks!

Adding this confirmation based on Tyler's feedback in Tuesday's bugbash.

@fredzqm fredzqm enabled auto-merge (squash) October 13, 2025 20:58
@fredzqm fredzqm merged commit f29c7ec into master Oct 13, 2025
48 checks passed
@fredzqm fredzqm deleted the feat-dataconnect-gemini-confirm branch October 13, 2025 21:11
@github-project-automation github-project-automation bot moved this from Approved [PR] to Done in [Cloud] Extensions + Functions Oct 13, 2025
joehan pushed a commit that referenced this pull request Oct 14, 2025
* Remove overrides that diverge the test configuration from the build configuration. (#9300)

Co-authored-by: Jamie Rothfeder <[email protected]>

* Fix misleading typing for options.json. (#9275)

* feat(dataconnect): Add confirmation for Gemini schema generation (#9282)

* feat(dataconnect): add confirmation for Gemini schema generation

Instead of directly asking for an app description to generate a schema with Gemini, this change first asks the user to confirm if they want to use Gemini.

If the user confirms, it then prompts for the app description with a default value of "an app for ${setup.projectId}".

* prompts

* changelog

* m

* feedback

* typo

* metrics

* Update index.ts

---------

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>

---------

Co-authored-by: Jamie Rothfeder <[email protected]>
Co-authored-by: Jamie Rothfeder <[email protected]>
Co-authored-by: Yuchen Shi <[email protected]>
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants