-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Prototype adding TODOs to the init prompt #9277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @samedson, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new mechanism to enhance the model's ability to manage multi-step initialization processes within Firebase projects. By instructing the model to maintain a Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a prototyping change to have the language model maintain a TODO list to better track its progress through multi-step tasks. The changes are consistently applied across the init
prompt and several resource guides. My feedback focuses on refining one of the prompt instructions to be more explicit, aligning with the goal you've outlined in the pull request description to have the model work with resource URIs directly.
2. Use the Firebase \`read_resources\` tool to load the guide to setup the product you choose. | ||
The user will likely need to setup Firestore, Authentication, and Hosting. Read the following guides in order: | ||
The user will likely need to setup Firestore, Authentication, and Hosting. Read the following guides in order and add each guide as a step to the FIREBASE_INIT_TODO.md file or using the TODO tool: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you noted in the PR description, it's important for the model to list resource names/URIs directly. The current instruction 'add each guide as a step' is a bit ambiguous and might lead the model to create a summarized task instead of one to read the resource.
Making this more explicit will improve the model's ability to follow the steps correctly.
The user will likely need to setup Firestore, Authentication, and Hosting. Read the following guides in order and add each guide as a step to the FIREBASE_INIT_TODO.md file or using the TODO tool: | |
The user will likely need to setup Firestore, Authentication, and Hosting. Read the following guides in order and add each guide's resource URI as a step to the FIREBASE_INIT_TODO.md file or using the TODO tool: |
This still needs some work, but it improves the model's ability to work through many steps.
https://screencast.googleplex.com/cast/NTIwNDM2NzU4OTI0NDkyOHw3NGM1YmI2MS1mZA