Implement dataconnect:execute command. #9274
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6-beta.1
yuchenshi
commented
Oct 7, 2025
| }); | ||
| } | ||
|
|
||
| // Log the body to stdout to allow pipe processing (even with .errors). |
There was a problem hiding this comment.
This doesn't work quite nicely since errors thrown (below, if any) are also logged to stdout (globally handled). Piping to jq for example can choke on the extra output
yuchenshi
commented
Oct 7, 2025
| } else { | ||
| if (fileOrConnector === "-") { | ||
| stdinUsedFor = "operation source code"; | ||
| if (process.stdin.isTTY) { |
There was a problem hiding this comment.
As discussed internally, I tried to throw an error if options.nonInteractive but that creates a false positive when --json is passed, since --json right now implies options.nonInteractive (handled globally).
I don't think erroring on --json matches user intention, so I left that part out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a new command to execute Data Connect operations.
DO NOT MERGE: API still in review.
Scenarios Tested
See Sample Commands below for more.
Sample Commands