Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep artifact registry dry run off for policy changes #8419

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

colerogers
Copy link
Contributor

Fixes #8418

It seems that the Repository resource has the field cleanupPolicyDryRun set to true by default on the GCF repos. This change fixes forces that field to be false when using the firebase functions:artifacts:setpolicy command.

Copy link
Contributor

@taeold taeold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow great catch 😭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New cleanup policy applying in Dry Run mode
2 participants