Build out e2e subdirectories #9065
Conversation
|
Vertex AI Mock Responses Check
|
Size Report 1Affected ProductsNo changes between base commit (40be2db) and merge commit (9467da4).Test Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (40be2db) and merge commit (9467da4).Test Logs |
.github/workflows/e2e-test.yml
Outdated
| env: | ||
| VERSION: ${{ github.event.client_payload.versionOrTag }} | ||
| - name: Yarn install | ||
| run: | | ||
| echo "Installing firebase@${{ github.event.client_payload.versionOrTag }}" | ||
| yarn add firebase@${{ github.event.client_payload.versionOrTag }} | ||
| yarn add firebase@11.8.1 |
There was a problem hiding this comment.
Was this meant to be hard coded?
| * limitations under the License. | ||
| */ | ||
|
|
||
| console.log('hello'); |
There was a problem hiding this comment.
Could the template have an example that initializes Firebase App?
There was a problem hiding this comment.
I'm trying to keep the template as minimal as possible, I just want to show the file structure. I don't want to make any assumptions about what kind of project might be here.
Put e2e smoke tests in a subdirectory under
e2e/, allowing other e2e directories to be created that do not impact the shared monorepo npm/yarn workspaces.