Skip to content

Fix issue where we ping an endpoint that hasn't been implemented #9059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

maneesht
Copy link
Contributor

When attempting to get cookies for the storage emulator, the endpoint returns with 501 because / hasn't been implemented. Instead, we should be calling /.

@maneesht maneesht requested review from tonyjhuang and a team as code owners May 23, 2025 18:02
Copy link

changeset-bot bot commented May 23, 2025

🦋 Changeset detected

Latest commit: d15eeea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/storage Patch
firebase Patch
@firebase/storage-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_vertexai_responses.sh should be updated to clone the latest version of the responses: v13.0

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 23, 2025

Size Report 1

Affected Products

  • @firebase/storage

    TypeBase (d5e5795)Merge (b39c501)Diff
    browser58.5 kB58.5 kB+2 B (+0.0%)
    main60.0 kB60.0 kB+2 B (+0.0%)
    module58.5 kB58.5 kB+2 B (+0.0%)
  • bundle

    TypeBase (d5e5795)Merge (b39c501)Diff
    storage (getBytes)47.2 kB47.2 kB+2 B (+0.0%)
    storage (getDownloadURL)49.2 kB49.2 kB+2 B (+0.0%)
    storage (getMetadata)48.7 kB48.7 kB+2 B (+0.0%)
    storage (list + listAll)48.1 kB48.1 kB+2 B (+0.0%)
    storage (updateMetadata)49.0 kB49.0 kB+2 B (+0.0%)
    storage (uploadBytes)53.8 kB53.8 kB+2 B (+0.0%)
    storage (uploadBytesResumable)63.8 kB63.8 kB+2 B (+0.0%)
    storage (uploadString)54.0 kB54.0 kB+2 B (+0.0%)
  • firebase

    TypeBase (d5e5795)Merge (b39c501)Diff
    firebase-compat.js802 kB802 kB+4 B (+0.0%)
    firebase-storage-compat.js44.2 kB44.2 kB+4 B (+0.0%)
    firebase-storage.js51.1 kB51.1 kB+2 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/hMfmTBZSCJ.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 23, 2025

Size Analysis Report 1

Affected Products

  • @firebase/storage

    • connectStorageEmulator

      Size

      TypeBase (d5e5795)Merge (b39c501)Diff
      size11.8 kB11.8 kB+2 B (+0.0%)
      size-with-ext-deps34.8 kB34.8 kB+2 B (+0.0%)
    • getStorage

      Size

      TypeBase (d5e5795)Merge (b39c501)Diff
      size12.0 kB12.0 kB+2 B (+0.0%)
      size-with-ext-deps42.7 kB42.7 kB+2 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/CSgxwnMgkl.html

@maneesht maneesht requested review from a team as code owners May 23, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants