-
Notifications
You must be signed in to change notification settings - Fork 952
FDC Parsing Improvements #8892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
maneesht
wants to merge
13
commits into
main
Choose a base branch
from
mtewani/fix-fdc-env-parsing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
FDC Parsing Improvements #8892
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
7d0ba34
WIP
maneesht 8c7f285
Fixed parsing
maneesht ba0b1bd
Fixed formatting
maneesht f3b826a
Included ipv6 parsing
maneesht 5db3e15
Updated api changes
maneesht cb29de0
Added back port usage
maneesht 2a02c9e
Added back tests
maneesht bb812d7
Trimmed hostname
maneesht a89fc04
Updated signature
maneesht f7d65ba
Fixed non-http protocols
maneesht 55502d9
Create hip-chefs-attack.md
maneesht 8e6d81a
Added extra test
maneesht c37c5a6
Merge branch 'mtewani/fix-fdc-env-parsing' of https://github.com/fire…
maneesht File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@firebase/data-connect": patch | ||
--- | ||
|
||
Fix issue where ipv6 addresses weren't getting parsed correctly when setting FIREBASE_DATA_CONNECT_EMULATOR_HOST |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
1 change: 0 additions & 1 deletion
1
packages/data-connect/test/dataconnect/logAddMovieVariables.json
This file was deleted.
Oops, something went wrong.
1 change: 0 additions & 1 deletion
1
packages/data-connect/test/dataconnect/logListAllMoviesMovies.json
This file was deleted.
Oops, something went wrong.
1 change: 0 additions & 1 deletion
1
packages/data-connect/test/dataconnect/logListMovieIdsMovies.json
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.