Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter empty text parts when streaming #8736

Merged
merged 10 commits into from
Feb 12, 2025
Merged

Filter empty text parts when streaming #8736

merged 10 commits into from
Feb 12, 2025

Conversation

dlarocque
Copy link
Contributor

@dlarocque dlarocque commented Jan 28, 2025 •
edited
Loading

Fixes #8714

When streaming responses, remove all empty text parts, since if we send these to the backend we'll get an error.

If a response contained only empty text parts, an error will be thrown in validateChatHistory for the candidate having no parts in it's content.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 28, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 0c10984

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@firebase/vertexai Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 28, 2025 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/app

    TypeBase (dafae52)Merge (ec6f74e)Diff
    browser19.5 kB19.5 kB-1 B (-0.0%)
    main20.4 kB20.4 kB-1 B (-0.0%)
    module19.5 kB19.5 kB-1 B (-0.0%)

  • @firebase/auth

    TypeBase (dafae52)Merge (ec6f74e)Diff
    browser188 kB189 kB+469 B (+0.2%)
    cordova164 kB164 kB+469 B (+0.3%)
    main145 kB145 kB+469 B (+0.3%)
    module188 kB189 kB+469 B (+0.2%)
    react-native163 kB164 kB+469 B (+0.3%)

  • @firebase/auth-cordova

    TypeBase (dafae52)Merge (ec6f74e)Diff
    browser164 kB164 kB+469 B (+0.3%)
    module164 kB164 kB+469 B (+0.3%)

  • @firebase/auth-web-extension

    TypeBase (dafae52)Merge (ec6f74e)Diff
    browser140 kB140 kB+469 B (+0.3%)
    main157 kB158 kB+469 B (+0.3%)
    module140 kB140 kB+469 B (+0.3%)

  • @firebase/auth/internal

    TypeBase (dafae52)Merge (ec6f74e)Diff
    browser199 kB199 kB+469 B (+0.2%)
    main171 kB172 kB+471 B (+0.3%)
    module199 kB199 kB+469 B (+0.2%)

  • @firebase/data-connect

    TypeBase (dafae52)Merge (ec6f74e)Diff
    browser20.3 kB21.1 kB+835 B (+4.1%)
    main22.2 kB23.1 kB+933 B (+4.2%)
    module20.3 kB21.1 kB+835 B (+4.1%)

  • @firebase/database

    TypeBase (dafae52)Merge (ec6f74e)Diff
    browser249 kB249 kB+12 B (+0.0%)
    main254 kB254 kB+12 B (+0.0%)
    module249 kB249 kB+12 B (+0.0%)

  • @firebase/database-compat/standalone

    TypeBase (dafae52)Merge (ec6f74e)Diff
    main366 kB366 kB+123 B (+0.0%)

  • @firebase/firestore

    TypeBase (dafae52)Merge (ec6f74e)Diff
    browser380 kB381 kB+334 B (+0.1%)
    main589 kB589 kB+373 B (+0.1%)
    module380 kB381 kB+334 B (+0.1%)
    react-native380 kB381 kB+334 B (+0.1%)

  • @firebase/firestore-lite

    TypeBase (dafae52)Merge (ec6f74e)Diff
    browser112 kB112 kB+393 B (+0.4%)
    main154 kB154 kB+421 B (+0.3%)
    module112 kB112 kB+393 B (+0.4%)
    react-native112 kB112 kB+393 B (+0.4%)

  • @firebase/performance

    TypeBase (dafae52)Merge (ec6f74e)Diff
    browser30.6 kB30.6 kB-1 B (-0.0%)
    main31.1 kB31.1 kB-1 B (-0.0%)
    module30.6 kB30.6 kB-1 B (-0.0%)

  • @firebase/vertexai

    TypeBase (dafae52)Merge (ec6f74e)Diff
    browser29.0 kB29.2 kB+196 B (+0.7%)
    main29.9 kB30.0 kB+196 B (+0.7%)
    module29.0 kB29.2 kB+196 B (+0.7%)

  • bundle

    46 size changes

    TypeBase (dafae52)Merge (ec6f74e)Diff
    analytics (logEvent)44.7 kB44.7 kB-1 B (-0.0%)
    app-check (CustomProvider)37.4 kB37.4 kB-1 B (-0.0%)
    app-check (ReCaptchaEnterpriseProvider)39.9 kB39.9 kB-1 B (-0.0%)
    app-check (ReCaptchaV3Provider)39.9 kB39.9 kB-1 B (-0.0%)
    auth (Anonymous)76.5 kB76.6 kB+146 B (+0.2%)
    auth (EmailAndPassword)86.6 kB86.8 kB+146 B (+0.2%)
    auth (GoogleFBTwitterGitHubPopup)103 kB104 kB+146 B (+0.1%)
    auth (GooglePopup)101 kB101 kB+146 B (+0.1%)
    auth (GoogleRedirect)101 kB101 kB+146 B (+0.1%)
    auth (Phone)94.0 kB94.2 kB+146 B (+0.2%)
    database (Append to a list of data)150 kB150 kB+11 B (+0.0%)
    database (Filtering data)148 kB148 kB+11 B (+0.0%)
    database (Listen for child events)165 kB165 kB+11 B (+0.0%)
    database (Listen for value events + Detach listeners)165 kB165 kB+11 B (+0.0%)
    database (Listen for value events)165 kB165 kB+11 B (+0.0%)
    database (Read data once)164 kB164 kB+11 B (+0.0%)
    database (Save data as transactions)167 kB167 kB+11 B (+0.0%)
    database (Sort data)150 kB150 kB+11 B (+0.0%)
    database (Write data)149 kB149 kB+11 B (+0.0%)
    firestore (CSI Auto Indexing Disable and Delete)271 kB271 kB+195 B (+0.1%)
    firestore (CSI Auto Indexing Enable)271 kB271 kB+195 B (+0.1%)
    firestore (Persistence)302 kB303 kB+158 B (+0.1%)
    firestore (Query Cursors)249 kB250 kB+158 B (+0.1%)
    firestore (Query)247 kB247 kB+158 B (+0.1%)
    firestore (Read data once)235 kB235 kB+158 B (+0.1%)
    firestore (Read Write w Persistence)327 kB327 kB+158 B (+0.0%)
    firestore (Realtime updates)237 kB237 kB+158 B (+0.1%)
    firestore (Transaction)214 kB214 kB+195 B (+0.1%)
    firestore (Write data)214 kB214 kB+195 B (+0.1%)
    firestore-lite (Query Cursors)103 kB103 kB+195 B (+0.2%)
    firestore-lite (Query)99.2 kB99.4 kB+195 B (+0.2%)
    firestore-lite (Read data once)74.6 kB74.8 kB+195 B (+0.3%)
    firestore-lite (Transaction)99.9 kB100 kB+195 B (+0.2%)
    firestore-lite (Write data)84.2 kB84.4 kB+195 B (+0.2%)
    functions (call)34.8 kB34.8 kB-3 B (-0.0%)
    messaging (send + receive)47.5 kB47.5 kB-1 B (-0.0%)
    performance (trace)62.4 kB62.4 kB-2 B (-0.0%)
    remote-config (getAndFetch)47.7 kB47.7 kB-1 B (-0.0%)
    storage (getBytes)42.4 kB42.4 kB-1 B (-0.0%)
    storage (getDownloadURL)44.5 kB44.5 kB-1 B (-0.0%)
    storage (getMetadata)43.9 kB43.9 kB-1 B (-0.0%)
    storage (list + listAll)43.3 kB43.3 kB-1 B (-0.0%)
    storage (updateMetadata)44.2 kB44.2 kB-1 B (-0.0%)
    storage (uploadBytes)49.0 kB49.0 kB-1 B (-0.0%)
    storage (uploadBytesResumable)59.0 kB59.0 kB-1 B (-0.0%)
    storage (uploadString)49.3 kB49.3 kB-1 B (-0.0%)

  • firebase

    24 size changes

    TypeBase (dafae52)Merge (ec6f74e)Diff
    firebase-analytics-compat.js26.5 kB25.7 kB-795 B (-3.0%)
    firebase-app-check-compat.js23.2 kB22.6 kB-615 B (-2.6%)
    firebase-app-compat.js32.5 kB31.8 kB-701 B (-2.2%)
    firebase-app.js103 kB103 kB-1 B (-0.0%)
    firebase-auth-compat.js143 kB140 kB-3.36 kB (-2.3%)
    firebase-auth-cordova.js136 kB137 kB+444 B (+0.3%)
    firebase-auth-web-extension.js119 kB119 kB+444 B (+0.4%)
    firebase-auth.js155 kB155 kB+444 B (+0.3%)
    firebase-compat.js808 kB791 kB-16.8 kB (-2.1%)
    firebase-data-connect.js16.8 kB17.3 kB+554 B (+3.3%)
    firebase-database-compat.js166 kB164 kB-2.84 kB (-1.7%)
    firebase-database.js187 kB187 kB+12 B (+0.0%)
    firebase-firestore-compat.js345 kB339 kB-6.43 kB (-1.9%)
    firebase-firestore-lite.js130 kB131 kB+393 B (+0.3%)
    firebase-firestore.js439 kB439 kB+334 B (+0.1%)
    firebase-functions-compat.js10.6 kB10.4 kB-254 B (-2.4%)
    firebase-installations-compat.js13.3 kB12.9 kB-384 B (-2.9%)
    firebase-messaging-compat.js38.7 kB37.0 kB-1.64 kB (-4.2%)
    firebase-performance-compat.js40.9 kB40.0 kB-869 B (-2.1%)
    firebase-performance-standalone-compat.js105 kB105 kB-2 B (-0.0%)
    firebase-performance.js45.5 kB45.5 kB-1 B (-0.0%)
    firebase-remote-config-compat.js28.4 kB27.8 kB-564 B (-2.0%)
    firebase-storage-compat.js40.4 kB39.7 kB-690 B (-1.7%)
    firebase-vertexai.js24.0 kB24.4 kB+433 B (+1.8%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/fpEEkHFtLt.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 28, 2025 •
edited
Loading

Size Analysis Report 1

This report is too large (646,234 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/IWRmewaFlQ.html

@dlarocque dlarocque mentioned this pull request Jan 29, 2025
Closed
@dlarocque dlarocque marked this pull request as ready for review January 29, 2025 19:13
@dlarocque dlarocque requested review from a team as code owners January 29, 2025 19:13
@dlarocque dlarocque requested a review from hsubox76 January 29, 2025 19:17
@dlarocque dlarocque requested a review from hsubox76 January 31, 2025 17:19
@dlarocque dlarocque requested a review from hsubox76 February 3, 2025 20:03
@dlarocque dlarocque requested a review from DellaBitta February 7, 2025 21:20
@dlarocque dlarocque merged commit 554c7bd into main Feb 12, 2025
38 checks passed
@dlarocque dlarocque deleted the dl/streaming-empty-part branch February 12, 2025 17:43
@google-oss-bot google-oss-bot mentioned this pull request Feb 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsubox76 hsubox76 hsubox76 approved these changes

@DellaBitta DellaBitta Awaiting requested review from DellaBitta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sendMessageStream with history failing to fetch due to 'empty text parameter'
4 participants
@dlarocque @google-oss-bot @DellaBitta @hsubox76