Remove firebase-namespace-integration-test CI test #8092
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changeset File Check ✅
|
DellaBitta
approved these changes
Mar 22, 2024
Size Report 1Affected ProductsNo changes between base commit (9ca1a4e) and merge commit (19ee6f8).Test Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (9ca1a4e) and merge commit (19ee6f8).Test Logs |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test seems to be very outdated. It was introduced long before v9 to validate that no methods were missing or incorrect on the top-level Firebase namespaced object. We no longer have a namespaced API, so this test only applied to compat packages, and only a select few compat packages (the products that existed at the time this test was created).
I believe api-extractor serves the same purpose even better in our current setup.
Removing the test dir, the workflow, and already removed it in the repo settings as a required check on merge to master.