Refactored Number Coding in FunctionsSerializer
#14889
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback. |
* Introduced `WrappedNumber` as a type-safe wrapper for numeric values which have to be encoded / decoded to fit JS limits * Since numbers other than big integers don’t need special encoding, it’s not necessary to process them separately for each type—all numbers except `q` and `Q` are returned as is (just as before) * For decoding, wrapped numbers are parsed using Swift types `Int` and `UInt` * These changes further reduce the usage of Objective-C types, and make it easier to (de)serialize Functions payloads using `Codable` in the future
yakovmanshin
force-pushed
the
functions-number-coding
branch
from
ddc6d06 to
40bd5eb
Compare
| // Seems like we should throw here - but this maintains compatibility. | ||
| return dict |
There was a problem hiding this comment.
Dictionaries like this (with @type but no value) didn’t qualify to be decoded as numbers, yet they somehow managed to avoid normal processing, where each value is decoded and checked.
This is no longer the case: The object is either a valid WrappedNumber or treated like a generic dictionary, with no in-betweens.
| extension FunctionsSerializer { | ||
| enum Error: Swift.Error { | ||
| case unsupportedType(typeName: String) | ||
| case unknownNumberType(charValue: String, number: NSNumber) | ||
| case invalidValueForType(value: String, requestedType: String) | ||
| case failedToParseWrappedNumber(WrappedNumber) |
There was a problem hiding this comment.
WrappedNumber can be made private if this error case uses plain strings. I decided to go with the actual object to avoid the extra transformations, but I still have some reservations.
WrappedNumberas a type-safe wrapper for numeric values which have to be encoded / decoded to fit JS limitsqandQare returned as is (just as before)IntandUIntCodablein the future