Skip to content

[Infra] Common cocoapods pod lib lint job #14876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 58 commits into from
May 28, 2025
Merged

[Infra] Common cocoapods pod lib lint job #14876

merged 58 commits into from
May 28, 2025

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented May 20, 2025

I'd like to refactor down our workflows to:

  • consolidate where we are still using CocoaPods
  • standardize Xcode versioning strategy across all workflows (See comment)
  • reduce the amount of custom Xcode configuration (ideally it will only be done in a few files)

For follow-up work, there are a couple products's workflows that still need to be migrated.

Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

Copy link
Member Author

@ncooke3 ncooke3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Complete pass.

@ncooke3 ncooke3 marked this pull request as ready for review May 28, 2025 15:33
@ncooke3 ncooke3 closed this May 28, 2025
@ncooke3 ncooke3 reopened this May 28, 2025
Copy link
Member Author

@ncooke3 ncooke3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed --test-spec arg input

@ncooke3 ncooke3 requested review from andrewheard and paulb777 May 28, 2025 16:27
@ncooke3 ncooke3 requested a review from paulb777 May 28, 2025 20:46
@ncooke3 ncooke3 merged commit 588c023 into main May 28, 2025
197 of 199 checks passed
@ncooke3 ncooke3 deleted the nc/ci-improve branch May 28, 2025 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants