-
Notifications
You must be signed in to change notification settings - Fork 217
Add Firebase Data Connect v2 support #1727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: lj/fdc-support
Are you sure you want to change the base?
Conversation
13cbf42
to
52a95a3
Compare
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces support for Firebase Data Connect v2 with the onMutationExecuted
trigger. The changes are well-structured, including the new provider, unit tests, and necessary package configuration updates. I've identified a few type safety issues in the new provider implementation concerning the handling of optional parameters, which could lead to runtime errors. I've provided suggestions to address these. Additionally, I've included a recommendation for a minor refactoring to enhance code clarity.
Description
Adds basic FDC function trigger for onMutationExecuted
Includes unit tests, but missing integration tests, which will be included in a subsequent PR once the backend changes are completed. Also fixes a typo on an existing file
npm test
passes locallyInternal tracking bug: b/436623435
Code sample
Examples of how to use this
See go/fdc-eventarc-functions-sdk for more information