Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: precision timestamp detection issue #137

Merged
merged 3 commits into from
Oct 3, 2023

Conversation

ekalosak
Copy link
Contributor

@exaby73
Copy link
Contributor

exaby73 commented Sep 22, 2023

Hello @ekalosak. Could we add some tests for this to ensure no regression in the future?

@ekalosak
Copy link
Contributor Author

ekalosak commented Sep 22, 2023

@exaby73 yes I believe I clicked "allow edits from maintainers" so you should be able to modify freely. But more than that, I think this issue requires coordination with the firebase-tools maintainers. They released a new version which was not backwards compatible with firebase-functions-python.

There's not any testing to be done on the FFP side that will prevent such mistakes in the future. That will have to come from the firebase-tools folks, if they care to make releases backwards compatible with other parts of the FireBase ecosystem.

@exaby73
Copy link
Contributor

exaby73 commented Sep 25, 2023

Could you link the PR which added these non-backwards compatible changes so that I may have a look?

@ekalosak
Copy link
Contributor Author

Any updates? What's blocking merge?

@Salakar Salakar changed the title fix for imprecise time strings fix: precision timestamp detection issue Oct 3, 2023
@taeold taeold merged commit f463ed1 into firebase:main Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants