Skip to content

move off deprecated ubuntu image #1694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/android.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ concurrency:

jobs:
prepare_matrix:
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
outputs:
matrix_os: ${{ steps.export-result.outputs.matrix_os }}
matrix_architecture: ${{ steps.export-result.outputs.matrix_architecture }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-report.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
fail-fast: false
matrix:
test_set: [ general, firestore ]
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
name: generate-report-${{ matrix.test_set }}
steps:
- name: Pause 5 minutes to offset Firestore fetches.
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ concurrency:

jobs:
file_format_check:
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
with:
Expand All @@ -40,7 +40,7 @@ jobs:

check_integration_test_labels:
# This check fails if integration tests are queued, in progress, or failed.
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
steps:
- uses: docker://agilepathway/pull-request-label-checker:latest
with:
Expand All @@ -49,7 +49,7 @@ jobs:

generated_docs_check:
# This check succeeds if Doxygen documentation generates without errors.
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
with:
Expand Down Expand Up @@ -88,7 +88,7 @@ jobs:

copyright_check:
# Check for Google copyright in each file.
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
with:
Expand All @@ -100,7 +100,7 @@ jobs:

release_notes_check:
# Check that the readme was updated, unless the PR has a specific label set (env.skipReleaseNotesLabel).
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
# Skip this if the PR has the skipReleaseNotes label or if it's a merge to other than main.
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/checks_secure.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ concurrency:
jobs:
dismiss_stale_approvals:
# Dismiss stale approvals for users without write access, or if this PR comes from a fork.
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
# Only if another commit was added to the PR.
steps:
- name: Check user permission
Expand Down
50 changes: 25 additions & 25 deletions .github/workflows/cpp-packaging.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ env:
jobs:
log_inputs:
name: log-inputs
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
steps:
- name: log run inputs
run: |
Expand Down Expand Up @@ -79,9 +79,9 @@ jobs:
if: ${{ github.event.inputs.downloadPublicVersion == '' && github.event.inputs.downloadPreviousRun == '' }}
strategy:
matrix:
os: [ubuntu-20.04, macos-13]
os: [ubuntu-latest, macos-13]
include:
- os: ubuntu-20.04
- os: ubuntu-latest
tools_platform: linux
# Binutils 2.35.1 released Sep 19, 2020
binutils_version: "2.35.1"
Expand Down Expand Up @@ -243,7 +243,7 @@ jobs:

build_and_package_android:
name: build-and-package-android
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
if: ${{ github.event.inputs.downloadPublicVersion == '' && github.event.inputs.downloadPreviousRun == '' }}
strategy:
fail-fast: false
Expand Down Expand Up @@ -308,7 +308,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [windows-latest, ubuntu-20.04, macos-13]
os: [windows-latest, ubuntu-latest, macos-13]
build_type: ["Release", "Debug"]
architecture: ["x64", "x86", "arm64"]
msvc_runtime: ["static", "dynamic"]
Expand All @@ -322,7 +322,7 @@ jobs:
msvc_runtime: "dynamic"
vcpkg_triplet_suffix: "windows-static-md"
sdk_platform: "windows"
- os: ubuntu-20.04
- os: ubuntu-latest
vcpkg_triplet_suffix: "linux"
additional_build_flags: ""
sdk_platform: "linux"
Expand All @@ -342,11 +342,11 @@ jobs:
linux_abi: "c++11"
- os: macos-13
build_type: "Debug"
- os: ubuntu-20.04
- os: ubuntu-latest
msvc_runtime: "dynamic"
- os: ubuntu-20.04
- os: ubuntu-latest
build_type: "Debug"
- os: ubuntu-20.04
- os: ubuntu-latest
architecture: "arm64"
- os: windows-latest
architecture: "arm64"
Expand Down Expand Up @@ -465,40 +465,40 @@ jobs:
matrix:
sdk_platform: [linux, darwin, windows]
suffix: ['']
runs_on_platform: [ubuntu-20.04]
runs_on_platform: [ubuntu-latest]
include:
# Split windows packaging into multiple runners.
- sdk_platform: windows
suffix: '-x86-Release-static'
runs_on_platform: ubuntu-20.04
runs_on_platform: ubuntu-latest
- sdk_platform: windows
suffix: '-x86-Release-dynamic'
runs_on_platform: ubuntu-20.04
runs_on_platform: ubuntu-latest
- sdk_platform: windows
suffix: '-x64-Release-static'
runs_on_platform: ubuntu-20.04
runs_on_platform: ubuntu-latest
- sdk_platform: windows
suffix: '-x64-Release-dynamic'
runs_on_platform: ubuntu-20.04
runs_on_platform: ubuntu-latest
- sdk_platform: windows
suffix: '-x86-Debug-static'
runs_on_platform: ubuntu-20.04
runs_on_platform: ubuntu-latest
- sdk_platform: windows
suffix: '-x86-Debug-dynamic'
runs_on_platform: ubuntu-20.04
runs_on_platform: ubuntu-latest
- sdk_platform: windows
suffix: '-x64-Debug-static'
runs_on_platform: ubuntu-20.04
runs_on_platform: ubuntu-latest
- sdk_platform: windows
suffix: '-x64-Debug-dynamic'
runs_on_platform: ubuntu-20.04
runs_on_platform: ubuntu-latest
- sdk_platform: darwin
runs_on_platform: macos-13
exclude:
- sdk_platform: windows
suffix: ''
- sdk_platform: darwin
runs_on_platform: ubuntu-20.04
runs_on_platform: ubuntu-latest
steps:
- name: setup Xcode version (macos)
if: runner.os == 'macOS'
Expand Down Expand Up @@ -656,7 +656,7 @@ jobs:

download_sdk_package:
name: download-sdk-package
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
needs: [log_inputs]
if: ${{ github.event.inputs.downloadPublicVersion != '' || github.event.inputs.downloadPreviousRun != '' }}
steps:
Expand Down Expand Up @@ -706,7 +706,7 @@ jobs:

merge_packages:
name: final-merge-packages
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
if: ${{ github.event.inputs.downloadPublicVersion == '' && github.event.inputs.downloadPreviousRun == '' }}
needs: [build_and_package_ios_tvos, build_and_package_android, package_desktop, log_inputs]
steps:
Expand Down Expand Up @@ -767,7 +767,7 @@ jobs:

create_windows_only_package:
name: create-windows-only-package
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
needs: [merge_packages]
steps:
- name: download SDK zip
Expand Down Expand Up @@ -814,7 +814,7 @@ jobs:
# Clean up intermediate artifacts from packaging step.
# This can happen after the final package merge is finished.
name: cleanup-packaging-artifacts
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
needs: [merge_packages]
if: |
(
Expand All @@ -835,7 +835,7 @@ jobs:
# Trigger the integration_tests workflow.
needs: [merge_packages, download_sdk_package, create_windows_only_package, cleanup_packaging_artifacts]
if: (github.event.inputs.skipIntegrationTests == 0 || github.event.inputs.skipIntegrationTests == '') && !cancelled() && !failure()
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
steps:
- name: Checkout repo
uses: actions/checkout@v3
Expand Down Expand Up @@ -904,7 +904,7 @@ jobs:
attempt_retry:
name: "attempt-retry"
needs: [trigger_integration_tests]
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
if: ${{ failure() && !cancelled() && github.event_name == 'schedule' }}
steps:
- name: Checkout repo
Expand Down
22 changes: 11 additions & 11 deletions .github/workflows/desktop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ concurrency:

jobs:
prepare_matrix:
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
outputs:
matrix_os: ${{ steps.export-result.outputs.matrix_os }}
matrix_build_type: ${{ steps.export-result.outputs.matrix_build_type }}
Expand Down Expand Up @@ -70,24 +70,24 @@ jobs:
msvc_runtime: "dynamic"
exclude:
# msvc_runtime excludes
- os: ubuntu-20.04
- os: ubuntu-latest
msvc_runtime: "dynamic"
- os: macos-13
msvc_runtime: "dynamic"
# architecture excluees
- os: macos-13
architecture: "x86"
# Xcode excludes -- allow only one on osx and linux
- os: ubuntu-20.04
- os: ubuntu-latest
xcode_version: "11.7"
- os: windows-latest
xcode_version: "11.7"
- os: ubuntu-20.04
- os: ubuntu-latest
xcode_version: "12.5.1"
- os: windows-latest
xcode_version: "12.5.1"
# arm64 is only for macos
- os: ubuntu-20.04
- os: ubuntu-latest
architecture: "arm64"
- os: windows-latest
architecture: "arm64"
Expand Down Expand Up @@ -292,7 +292,7 @@ jobs:
### It's possible to add more apps here once integration tests are less flaky.
name: local-integration-tests-linux-openssl
needs: prepare_matrix
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
strategy:
fail-fast: false
steps:
Expand Down Expand Up @@ -331,15 +331,15 @@ jobs:
python scripts/gha/build_testapps.py --p Desktop \
--t ${apis} \
--output_directory "${{ github.workspace }}" \
--artifact_name "desktop-ubuntu-20.04-openssl" \
--artifact_name "desktop-ubuntu-latest-openssl" \
--noadd_timestamp \
--short_output_paths \
--cmake_flag=-DFIREBASE_QUICK_TEST=ON
- name: Summarize build results
if: ${{ !cancelled() }}
shell: bash
run: |
cat build-results-desktop-ubuntu-20.04-openssl.log
cat build-results-desktop-ubuntu-latest-openssl.log
if [[ "${{ job.status }}" != "success" ]]; then
exit 1
fi
Expand All @@ -361,15 +361,15 @@ jobs:
java-version: '17'
- name: Run Desktop integration tests
run: |
cp scripts/gha/integration_testing/google-services.json testapps-desktop-ubuntu-20.04-openssl/firestore/google-services.json
firebase emulators:exec --only firestore --project demo-example 'python scripts/gha/desktop_tester.py --testapp_dir testapps-desktop-ubuntu-20.04-openssl --logfile_name "desktop-ubuntu-20.04-openssl"'
cp scripts/gha/integration_testing/google-services.json testapps-desktop-ubuntu-latest-openssl/firestore/google-services.json
firebase emulators:exec --only firestore --project demo-example 'python scripts/gha/desktop_tester.py --testapp_dir testapps-desktop-ubuntu-latest-openssl --logfile_name "desktop-ubuntu-latest-openssl"'
env:
USE_FIRESTORE_EMULATOR: true
- name: Summarize test results
if: ${{ !cancelled() }}
shell: bash
run: |
cat testapps-desktop-ubuntu-20.04-openssl/test-results-desktop-ubuntu-20.04-openssl.log
cat testapps-desktop-ubuntu-latest-openssl/test-results-desktop-ubuntu-latest-openssl.log
if [[ "${{ job.status }}" != "success" ]]; then
exit 1
fi
16 changes: 8 additions & 8 deletions .github/workflows/integration_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ on:
required: true
operating_systems:
description: 'CSV of VMs to run on'
default: 'ubuntu-20.04,windows-latest,macos-13'
default: 'ubuntu-latest,windows-latest,macos-13'
required: true
desktop_ssl_variants:
description: 'CSV of desktop SSL variants to use'
Expand Down Expand Up @@ -58,7 +58,7 @@ env:

jobs:
check_and_prepare:
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
outputs:
trigger: ${{ steps.set_outputs.outputs.trigger }}
github_ref: ${{ steps.set_outputs.outputs.github_ref }}
Expand Down Expand Up @@ -204,7 +204,7 @@ jobs:
# at 3am PST/4am PDT. Running firestore desktop integration test aginst tip-of-tree ios repo
echo "::warning ::Running against Firestore tip-of-tree"
matrix_platform="Desktop"
matrix_os=$( python scripts/gha/print_matrix_configuration.py -w integration_tests ${TEST_MATRIX_PARAM} -k os -o "ubuntu-20.04,macos-13")
matrix_os=$( python scripts/gha/print_matrix_configuration.py -w integration_tests ${TEST_MATRIX_PARAM} -k os -o "ubuntu-latest,macos-13")
else
matrix_platform=$( python scripts/gha/print_matrix_configuration.py -w integration_tests ${TEST_MATRIX_PARAM} -k platform -o "${{github.event.inputs.platforms}}" --apis ${apis} )
matrix_os=$( python scripts/gha/print_matrix_configuration.py -w integration_tests ${TEST_MATRIX_PARAM} -k os -o "${{github.event.inputs.operating_systems}}")
Expand Down Expand Up @@ -268,7 +268,7 @@ jobs:
# Do not attempt to use arm64 on Windows or Linux.
- os: windows-latest
arch: arm64
- os: ubuntu-20.04
- os: ubuntu-latest
arch: arm64
# Do not attempt to use x86 on Mac.
- os: macos-13
Expand Down Expand Up @@ -750,7 +750,7 @@ jobs:
# Do not attempt to use arm64 on Windows or Linux.
- os: windows-latest
arch: arm64
- os: ubuntu-20.04
- os: ubuntu-latest
arch: arm64
# Do not attempt to use x86 on Mac.
- os: macos-13
Expand Down Expand Up @@ -867,7 +867,7 @@ jobs:
test_android:
name: test-android-${{ matrix.build_os }}-${{ matrix.android_device }}-${{ matrix.test_type }}
needs: [check_and_prepare, build_android]
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
if: contains(needs.check_and_prepare.outputs.matrix_platform, 'Android') && needs.check_and_prepare.outputs.apis != '' && !cancelled()
strategy:
fail-fast: false
Expand Down Expand Up @@ -1313,7 +1313,7 @@ jobs:
summarize_results:
name: "summarize-results"
needs: [check_and_prepare, test_desktop, test_android, test_ios, test_tvos]
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
if: ${{ !cancelled() }}
steps:
- uses: actions/checkout@v3
Expand Down Expand Up @@ -1381,7 +1381,7 @@ jobs:
attempt_retry:
name: "attempt-retry"
needs: [check_and_prepare, summarize_results]
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
if: ${{ failure() && needs.check_and_prepare.outputs.trigger == 'scheduled_trigger' }}
steps:
- uses: actions/checkout@v3
Expand Down
Loading
Loading