Skip to content

Internal Updates #1595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nakirekommula merged 9 commits into from
May 30, 2024
Merged

Internal Updates #1595

nakirekommula merged 9 commits into from
May 30, 2024

Conversation

@nakirekommula
Copy link
Contributor

@nakirekommula nakirekommula commented May 23, 2024

Description

Enables QueryInfo generation for supporting S2S workflow.

Testing

Tested on both Android and iOS platforms for the APIs added.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

PR contains multiple commits breaking down the changes to help with reviewing.

@nakirekommula nakirekommula added the skip-release-notes Skip release notes check label May 23, 2024
github-actions[bot]
github-actions bot reviewed May 23, 2024
View reviewed changes
@nakirekommula nakirekommula requested a review from jonsimantov May 23, 2024 22:47
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label May 29, 2024
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels May 29, 2024
@github-actions
Copy link

github-actions bot commented May 29, 2024 •
edited
Loading

❌  Integration test FAILED

Requested by @nakirekommula on commit 93bd9be
Last updated: Thu May 30 13:53 PDT 2024
View integration test log & download artifacts

Failures Configs
database [TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT
firestore [TEST] [FLAKINESS] [Android] [1/3 os: windows] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT
gma [TEST] [ERROR] [Android] [1/3 os: macos] [1/2 android_device: android_target]
storage [TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: emulator_ftl_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@nakirekommula nakirekommula added tests-requested: quick Trigger a quick set of integration tests. and removed tests: in-progress This PR's integration tests are in progress. labels May 29, 2024
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. labels May 29, 2024
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 30, 2024
@github-actions github-actions bot added tests: succeeded This PR's integration tests succeeded. and removed tests: failed This PR's integration tests failed. labels May 30, 2024
@nakirekommula nakirekommula merged commit 93bd9be into main May 30, 2024
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests: succeeded This PR's integration tests succeeded. labels May 30, 2024
@nakirekommula
Copy link
Contributor Author

nakirekommula commented May 30, 2024

Thank you for the review!

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label May 30, 2024
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 30, 2024
@firebase firebase locked and limited conversation to collaborators Jul 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

+1 more reviewer

@jonsimantov jonsimantov jonsimantov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nakirekommula @jonsimantov