Skip to content

Remove invalid iOS device from test list #1572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Remove invalid iOS device from test list #1572

merged 1 commit into from
Apr 18, 2024

Conversation

a-maurice
Copy link
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

FTL removed ipadmini4 from the supported devices, so remove it from our list.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@a-maurice a-maurice added the skip-release-notes Skip release notes check label Apr 18, 2024
@a-maurice a-maurice enabled auto-merge (squash) April 18, 2024 22:32
@a-maurice a-maurice merged commit e877b22 into main Apr 18, 2024
35 of 47 checks passed
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Apr 18, 2024
Copy link

github-actions bot commented Apr 18, 2024

Integration test with FLAKINESS (succeeded after retry)

Requested by @a-maurice on commit e877b22
Last updated: Thu Apr 18 18:35 PDT 2024
View integration test log & download artifacts

Failures Configs
installations [TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: emulator_ftl_target]
(1 failed tests)  FirebaseInstallationsTest.TestGetTokenForceRefresh
remote_config [TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/2 android_device: emulator_ftl_target]
(1 failed tests)  FirebaseRemoteConfigTest.TestFetchInterval

Add flaky tests to go/fpl-cpp-flake-tracker

@a-maurice a-maurice deleted the am-ftl_ios_update branch April 18, 2024 23:50
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Apr 19, 2024
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Apr 19, 2024
@firebase firebase locked and limited conversation to collaborators May 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants