dataconnect(test): QueryCachingIntegrationTest.kt added#7854
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. |
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces integration tests for query caching, which is a great addition. The refactoring to support passing CacheSettings is clean and well-executed throughout the modified files. I've found one potential issue in the new test file regarding test isolation in property-based tests, for which I've left a comment with a suggestion.
This PR adds
QueryCachingIntegrationTest.ktto dataconnect's integration test suite. It performs some basic tests that results are served from cache when expected. The suite will be enhanced to test entity normalization in a future PR.Highlights
QueryCachingIntegrationTestto test thatQueryRef.execute()returns cached or non-cached results, depending on the scenario.Quintupledata class, similar to theTripleclass from the Kotlin standard library.Changelog
Changelog
DataConnectBackend.kt:DataConnectBackendinterface to acceptCacheSettingsforgetDataConnectSettingsandgetDataConnectfunctions.DataConnectBackendsealed classes.TestDataConnectFactory.kt:newInstanceoverloads toTestDataConnectFactoryto supportCacheSettings.createInstanceto passCacheSettingsto theDataConnectBackend.cacheSettingsinTestDataConnectFactory.Params.TestConnectorFactory.kt:TestConnectorFactoryto acceptCacheSettingsin itscreateInstancemethod.dataConnectSettingsretrieval to usegetDataConnectSettings(params).QueryCachingIntegrationTest.kt:CacheSettings(disabled, memory, persistent),maxAge(1.hour, 1.nanosecond, ZERO), andFirebaseDataConnectinstance usage (same, new).KotestTestutilPrinters.kt:QuintuplePrintto register a custom printer for theQuintupleclass in Kotest.Quintuple.kt:Quintupleto hold five values, extending test utility functionality.