-
Notifications
You must be signed in to change notification settings - Fork 331
Added minimal support for sending FCM messages in async using HTTP/2 #870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
cae8f33
httpx async_send_each prototype
jonathanedey e3aa0db
Clean up code and lint
jonathanedey a8aa968
fix: Add extra dependancy for http2
jonathanedey 3343e25
fix: reset message batch limit to 500
jonathanedey 7a5f245
fix: Add new import to `setup.py`
jonathanedey File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we discussed offline, let's confirm if this complex code path is necessary for error handling. If it is not, let's clean it up and keep it simple :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we use this map FCM specific errors like:
We map to these errors by parsing the error response details. The default
handle_func
(handle_X_error
) is agnostic to the source service of the error and doesn't try to parse based the error response details. FCM is the only service that currently makes use of this optionalhandle_func
but this seems like the correct way to support this scenario.We could move the logic from the helper function
_handle_func_X
tohandle_platform_error_from_X
.Will merge as is and we can revisit this in a follow up PR if necessary.