Skip to content

Implementation of Evaluate (percent condition only) #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 11, 2025

Conversation

Namyalg
Copy link

@Namyalg Namyalg commented Apr 10, 2025

Description of the changes

  • Server template types with a detailed description are added in server_template_types.go
  • server_template contains the logic that evaluates the template to return the config.
  • condition_evaluator contains the implementation of the condition type User in Random Percentage, custom signals will be added subsequently.

@Namyalg Namyalg force-pushed the ssrc-evaluate-dev branch from 4a98b1a to dcb8107 Compare April 10, 2025 14:00
@pijushcs pijushcs self-requested a review April 11, 2025 10:38
Copy link

@pijushcs pijushcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You may update the description to reflect the refactoring changes as well on the final PR.

@Namyalg Namyalg force-pushed the ssrc-evaluate-dev branch from ef08cb5 to 6cf5e60 Compare April 11, 2025 11:40
@Namyalg Namyalg merged commit edf6145 into ssrc-fetch-dev Apr 11, 2025
6 checks passed
Namyalg added a commit that referenced this pull request Apr 11, 2025
Add types for server template; implementation of evaluate and percent condition operator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants