Conversation
Trivial to inline!
|
Let's drop a package that hasn't been updated in 2+ years! |
Coverage Report✅ Coverage 74.58% meets 40% threshold Total Coverage: 74.58% Package Breakdown
Minimum threshold: 40% |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the dependency on package:googleapis_beta by refactoring the App Check token verification to use a manual REST call. The verifyAppCheckToken method has been updated to return a boolean instead of the raw API response. Review feedback highlights an outdated docstring regarding the return type and suggests making the JSON decoding logic more robust to handle potential parsing errors or type mismatches.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request removes the googleapis_beta dependency by implementing a manual REST call for App Check token verification. Feedback indicates that the new JSON parsing logic for the alreadyConsumed field is too restrictive and should handle cases where the field is omitted by defaulting to false, preventing unnecessary exceptions.
2 participants
Trivial to inline!