Skip to content

fix(ui_oauth): use dart.library.js_interop for Wasm-compatible imports #675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rexios80 wants to merge 3 commits into
base: main
Choose a base branch
from
+8 −3
Open

fix(ui_oauth): use dart.library.js_interop for Wasm-compatible imports #675

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5e21102
fix(ui_oauth): use dart.library.js_interop for Wasm-compatible imports
Rexios80 Jul 28, 2026
5773cd1
fix(ui_oauth): keep desktop_webview_auth out of the Wasm import graph
Rexios80 Aug 14, 2026
3113ff8
fix(ui_oauth): re-export Wasm-safe desktop_webview_auth libraries
Rexios80 Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/firebase_ui_oauth/lib/firebase_ui_oauth.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,13 @@
// BSD-style license that can be found in the LICENSE file.

export 'package:firebase_auth/firebase_auth.dart' show OAuthCredential;
export 'package:desktop_webview_auth/desktop_webview_auth.dart'
show AuthResult, ProviderArgs;

// Re-export Wasm-compatible libraries instead of `desktop_webview_auth`,
// which imports `dart:io`.
// ignore: implementation_imports
export 'package:desktop_webview_auth/src/auth_result.dart' show AuthResult;
// ignore: implementation_imports
export 'package:desktop_webview_auth/src/provider_args.dart' show ProviderArgs;
export 'package:desktop_webview_auth/google.dart';
export 'package:desktop_webview_auth/facebook.dart';
export 'package:desktop_webview_auth/twitter.dart';
Expand Down
2 changes: 1 addition & 1 deletion packages/firebase_ui_oauth/lib/src/oauth_provider.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import 'package:firebase_ui_auth/firebase_ui_auth.dart';
import 'package:firebase_ui_oauth/firebase_ui_oauth.dart';

import 'platform_oauth_sign_in.dart'
if (dart.library.html) 'platform_oauth_sign_in_web.dart';
if (dart.library.js_interop) 'platform_oauth_sign_in_web.dart';

/// A listener of the [OAuthProvider].
/// See also:
Expand Down
Loading