Skip to content

feat: add Facebook sign-out functionality #2287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
demolaf merged 6 commits into from
Dec 17, 2025
Merged

feat: add Facebook sign-out functionality #2287

demolaf merged 6 commits into from
Dec 17, 2025

Conversation

@demolaf
Copy link
Member

@demolaf demolaf commented Dec 11, 2025 •
edited
Loading

This PR fixes two critical issues in FirebaseUI-Android authentication

  • Facebook sign-out functionality: Makes Facebook sign-out testable and adds comprehensive tests for provider-specific sign-out behavior.
  • Error message visibility: Shows actual Firebase error messages instead of generic "Incorrect password" text.

@demolaf demolaf marked this pull request as draft December 11, 2025 23:15
@demolaf demolaf marked this pull request as ready for review December 16, 2025 14:10
@demolaf demolaf merged commit ac541ec into version-10.0.0-beta01 Dec 17, 2025
5 checks passed
@demolaf demolaf deleted the fix-fb-auth branch December 17, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lyokone Lyokone Lyokone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@demolaf @Lyokone @thatfiredev