Skip to content

Set isRootEntity to false for autoMapped properties in modelCoverage analysis #3468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

tomwilson-gs
Copy link
Contributor

@tomwilson-gs tomwilson-gs commented Mar 14, 2025

What type of PR is this?

  • Bug Fix

What does this PR do / why is it needed ?

  • Set isRootEntity to false for autoMapped properties in modelCoverage analysis to rectify pathToElement failures in Search Document generation
  • Added test case to cover autoMapped entities not being included in Search Document generation

Which issue(s) this PR fixes:

Other notes for reviewers:

Does this PR introduce a user-facing change?

@tomwilson-gs tomwilson-gs requested a review from a team as a code owner March 14, 2025 11:38
Copy link

github-actions bot commented Mar 14, 2025

Test Results

    2 files  ±0      2 suites  ±0   23s ⏱️ -1s
122 tests ±0  122 ✔️ ±0  0 💤 ±0  0 ±0 
244 runs  ±0  244 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 97da93b. ± Comparison against base commit af05a84.

♻️ This comment has been updated with latest results.

@tomwilson-gs tomwilson-gs force-pushed the tw-dataspace-doc-gen-fix branch from c7928fe to 92d4b32 Compare March 17, 2025 13:54
@tomwilson-gs tomwilson-gs changed the title Switch to lenientPathToElement in Search Document generation Exclude autoMapped elements in Search Document generation Mar 17, 2025
@tomwilson-gs tomwilson-gs force-pushed the tw-dataspace-doc-gen-fix branch from 92d4b32 to 95940e8 Compare March 19, 2025 15:13
@tomwilson-gs tomwilson-gs force-pushed the tw-dataspace-doc-gen-fix branch from 95940e8 to 97da93b Compare March 19, 2025 15:17
@tomwilson-gs tomwilson-gs changed the title Exclude autoMapped elements in Search Document generation Set isRootEntity to false for autoMapped properties in modelCoverage analysis Mar 19, 2025
@finos-admin
Copy link
Member

This PR is stale because it has been open for 30 days with no activity. Please remove stale label or add any comment to keep this open. Otherwise this will be closed in 5 days.

@finos-admin
Copy link
Member

This PR was closed because it has been inactive for 35 days. Please re-open if this PR is still relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants