This repository has been archived by the owner on Apr 14, 2023. It is now read-only.
1038 stdout json to use ndjson format #1393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuthullu
force-pushed
the
1038-stdout-json-to-use-ndjson-format
branch
from
787517f to
8acfd17
Compare
hashbyhayter
approved these changes
Oct 2, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes stdout json to be ndjson format, and adds a
--ndjsonflag so it can be turned off or on for stdout and file out respectivelyChanges
sequenceWriternot to wrap output in an array, and use a new line delimiter for root elementsJsonDataSetWriterto theJsonDataSetWriterFactoryJsonDataSetWriterIssue
Resolves #1038