Skip to content
This repository has been archived by the owner on Apr 14, 2023. It is now read-only.

Stdout JSON output should allow NDJSON format to be produced #1038

Closed
willsalt-sl opened this issue Jun 13, 2019 · 3 comments · Fixed by #1393
Closed

Stdout JSON output should allow NDJSON format to be produced #1038

willsalt-sl opened this issue Jun 13, 2019 · 3 comments · Fixed by #1393
Assignees

Comments

@willsalt-sl
Copy link
Contributor

willsalt-sl commented Jun 13, 2019

Feature Request

According to User Story #440, when a user specifies JSON output but does not specify an output file, output should be to stdout in NDJSON format rather than regular JSON.

When the stdout feature was implemented, this was not done.

Steps to reproduce

  1. Run a command that specifies JSON output to stdout

Note that normal JSON output is produced. We require NDJSON output to be produced.

@willsalt-sl willsalt-sl added the bug Something isn't working label Jun 13, 2019
@pdaulbyscottlogic
Copy link
Contributor

should this be a feature to add NDJSON as a separate output option (in addition to CSV and JSON)

@willsalt-sl
Copy link
Contributor Author

I had a discussion with @ms14981 earlier about the distinction between bugs and features - it's a fine dividing line and arguably is just a question of phrasing. I would class this as a bug, though, because we had a feature request, we closed that feature request, but we didn't implement part of it. The fact that we said we had done X but the system does not, in fact, do X, means that it is in my opinion a bug.

Whether we resolve it by adding NDJSON as a separate output format is a question of implementation more than anything else, as long as we meet the requirement that when JSON output is selected and output is to standard output, NDJSON output is what the program produces.

@pdaulbyscottlogic
Copy link
Contributor

@ms14981 ms14981 removed the bug Something isn't working label Sep 4, 2019
@ms14981 ms14981 changed the title Stdout JSON output should be in NDJSON format Stdout JSON output should allow NDJSON format to be produced Sep 4, 2019
@cuthullu cuthullu self-assigned this Oct 2, 2019
hashbyhayter added a commit that referenced this issue Oct 2, 2019
fix(#1038): corrected logic for useNdJson function
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants