H264inclient #398
Open
H264inclient #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -10,6 +10,7 @@ struct AllocateConference | |||
| { | |||
| utils::Optional<uint32_t> lastN; | |||
| bool useGlobalPort = true; | |||
| bool useH264 = false; | |||
There was a problem hiding this comment.
can we do it a little more generic? So if we want to support new video codec ion future (like vp9, vp10). We will flood this with booleans.
I believe we should have a field more generic, like:
videoCodec = "default | vp8 | h264" // default is the one that is on smb config
If it's given an unsupported value, http request should fail with 400.
This way we could add support to new codecs without API changes
There was a problem hiding this comment.
yes, I will fix that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added h264 support in simple client and allow selection of h264 at allocation of conference if h264 is also enabled in config.json.
Default is vp8.