Skip to content

pop() wasn't removing field meta state #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2019
Merged

pop() wasn't removing field meta state #33

merged 1 commit into from
Jul 15, 2019

Conversation

erikras
Copy link
Member

@erikras erikras commented Jul 15, 2019

Fixes #21.

@codecov
Copy link

codecov bot commented Jul 15, 2019

Codecov Report

Merging #33 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #33   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          10     10           
  Lines         139    145    +6     
  Branches       27     29    +2     
=====================================
+ Hits          139    145    +6
Impacted Files Coverage Δ
src/pop.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d76d377...bbc3c30. Read the comment docs.

@erikras erikras merged commit 3effa4d into master Jul 15, 2019
@erikras erikras deleted the fix-pop-bug branch July 15, 2019 12:36
@erikras
Copy link
Member Author

erikras commented Jul 15, 2019

Published in v3.0.0.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong fields state after pop and unshift
1 participant