Skip to content

Ability to cache specified HTTP headers. (v2) #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 12, 2019
Merged

Conversation

DGrudzynskyi
Copy link

Based on #126

But applied on top of latest version of dev branch with some changes:

  • Respect content headers as well as response header.
  • Do not serialize data inside the CacheOutputAttribute. Serialization may (or may not) be implemented in IApiOutputCache implementation, if needed. No need for client code to worry about it.
  • Include unit tests.

Also, there is a tiny fix for Get_until25012015_1700 test, as 2015 (and even 2018) has already passed by.

Copy link
Owner

@filipw filipw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice! thanks a lot

@filipw filipw merged commit e3a09e0 into filipw:dev Feb 12, 2019
@chuckwatson87-zz
Copy link

@DGrudzynskyi , It looks like this hasn't made it into a nuget package release, but is something we could likely use too. Have you used this code to persist headers in production?

@DGrudzynskyi
Copy link
Author

@chuckwatson87 yes, I did. Although It was quite long time ago and I just don't remember whether there were any project-specific amendments, not posted back to this repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants