Skip to content

Commit

Permalink
Stop referring to github.com/ipfs/go-ipfs-blockstore outside of lib
Browse files Browse the repository at this point in the history
  • Loading branch information
ribasushi authored and codefather-filestar committed Jun 17, 2021
1 parent 96029e9 commit 213d31d
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 8 deletions.
2 changes: 1 addition & 1 deletion documentation/en/architecture/architecture.md
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ FIXME: Maybe mention the `Batching` interface as the developer will stumble upon

FIXME: IPFS blocks vs Filecoin blocks ideally happens before this / here

The [`Blockstore` interface](`github.com/ipfs/go-ipfs-blockstore/blockstore.go`) structures the key-value pair
The [`Blockstore` interface](`github.com/filecoin-project/lotus/lib/blockstore.go`) structures the key-value pair
into the CID format for the key and the [`Block` interface](`github.com/ipfs/go-block-format/blocks.go`) for the value.
The `Block` value is just a raw string of bytes addressed by its hash, which is included in the CID key.

Expand Down
7 changes: 3 additions & 4 deletions lib/blockstore/memstore.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import (

blocks "github.com/ipfs/go-block-format"
"github.com/ipfs/go-cid"
blockstore "github.com/ipfs/go-ipfs-blockstore"
)

// MemStore is a terminal blockstore that keeps blocks in memory.
Expand All @@ -24,15 +23,15 @@ func (m MemStore) Has(k cid.Cid) (bool, error) {
func (m MemStore) View(k cid.Cid, callback func([]byte) error) error {
b, ok := m[k]
if !ok {
return blockstore.ErrNotFound
return ErrNotFound
}
return callback(b.RawData())
}

func (m MemStore) Get(k cid.Cid) (blocks.Block, error) {
b, ok := m[k]
if !ok {
return nil, blockstore.ErrNotFound
return nil, ErrNotFound
}
return b, nil
}
Expand All @@ -41,7 +40,7 @@ func (m MemStore) Get(k cid.Cid) (blocks.Block, error) {
func (m MemStore) GetSize(k cid.Cid) (int, error) {
b, ok := m[k]
if !ok {
return 0, blockstore.ErrNotFound
return 0, ErrNotFound
}
return len(b.RawData()), nil
}
Expand Down
2 changes: 1 addition & 1 deletion node/repo/fsrepo.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ import (
"sync"

"github.com/BurntSushi/toml"
"github.com/filecoin-project/lotus/lib/blockstore"
"github.com/ipfs/go-datastore"
fslock "github.com/ipfs/go-fs-lock"
blockstore "github.com/ipfs/go-ipfs-blockstore"
logging "github.com/ipfs/go-log/v2"
"github.com/mitchellh/go-homedir"
"github.com/multiformats/go-base32"
Expand Down
2 changes: 1 addition & 1 deletion node/repo/interface.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ package repo
import (
"errors"

"github.com/filecoin-project/lotus/lib/blockstore"
"github.com/ipfs/go-datastore"
blockstore "github.com/ipfs/go-ipfs-blockstore"
"github.com/multiformats/go-multiaddr"

"github.com/filecoin-project/lotus/extern/sector-storage/fsutil"
Expand Down
2 changes: 1 addition & 1 deletion node/repo/retrievalstoremgr/retrievalstoremgr_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,13 @@ import (
"github.com/ipfs/go-datastore"
"github.com/ipfs/go-datastore/query"
dss "github.com/ipfs/go-datastore/sync"
blockstore "github.com/ipfs/go-ipfs-blockstore"
format "github.com/ipfs/go-ipld-format"
dag "github.com/ipfs/go-merkledag"
"github.com/stretchr/testify/require"

"github.com/filecoin-project/go-multistore"

"github.com/filecoin-project/lotus/lib/blockstore"
"github.com/filecoin-project/lotus/node/repo/importmgr"
"github.com/filecoin-project/lotus/node/repo/retrievalstoremgr"
)
Expand Down

0 comments on commit 213d31d

Please sign in to comment.