Fix: Fixed an issue where the items count was sometimes incorrect in the Details Pane

[Anoop-2024si96509]

Resolved / Related Issues

• Closes Bug: Details pane folder count isn't always correct #17211

Steps used to test these changes

1. Tested if Details pane now shows accurate item counts matching the file list view based on user preferences like:
   i)Show\Hide Hidden files & folders
   ii)Show\Hide protected system files & folder
   iii)Every possible combination of above 2 cases.

[yaira2]

@Anoop-2024si96509 the commit history seems to be a bit messed up. Can you try rebasing from main (please let me know if you want any help with this)?

[Anoop-2024si96509]

@Anoop-2024si96509 the commit history seems to be a bit messed up. Can you try rebasing from main (please let me know if you want any help with this)?

@Anoop-2024si96509 the commit history seems to be a bit messed up. Can you try rebasing from main (please let me know if you want any help with this)?

@yaira2 okey. Yes I need few inputs from you.

My plan is to create a new clean branch from main and cherry-pick my commit. So here should I create a new PR or Change the PR to point to the new branch ?

[yaira2]

I suggest keeping the PR and just changing the branch.

[yaira2]

@Anoop-2024si96509 I updated the branch from main. Please confirm that everything is good and then sync your local branch with the remote to make sure it's up to date. I'll go ahead and mark the earlier comments as outdated.

[Anoop-2024si96509]

@Anoop-2024si96509 I updated the branch from main. Please confirm that everything is good and then sync your local branch with the remote to make sure it's up to date. I'll go ahead and mark the earlier comments as outdated.

Thanks @yaira2 All good, and my branch is now up to date., Kindly review my commit made to the file:
src/Files.App/ViewModels/UserControls/Previews/FolderPreviewViewModel.cs

[yaira2]

Is adding this method necessary? In theory, we should be able to use the same code that we do in the status bar.

[Anoop-2024si96509]

@yaira2 This is addressed now: (bd9a916)

[mdtauk]

Just so I am clear, the Details Pane will always show the total file and folder count, even with a filtered view right?

Where as the status bar can show a count for the current view, be it filtered or not filtered?

Hidden files exist, even if not viewed. And files not included in the filter still exist in the folder and it's folder size calculations?

[Anoop-2024si96509]

the Details Pane will always show the total file and folder count, even with a filtered view right?

Both the Details pane and the Status pane respect the filter settings and display the count according to how many files are viewable to the user.

1. Show Hidden files filter enabled:

1. Show Hidden file filter disabled:

[mdtauk]

the Details Pane will always show the total file and folder count, even with a filtered view right?

Both the Details pane and the Status pane respect the filter settings and display the count according to how many files are viewable to the user.

I am not sure I agree with that, as the Details pane should be a source of truth, and just because you are filtering the view, does not mean the folder's contents have changed.

[Anoop-2024si96509]

the Details Pane will always show the total file and folder count, even with a filtered view right?

Both the Details pane and the Status pane respect the filter settings and display the count according to how many files are viewable to the user.

I am not sure I agree with that, as the Details pane should be a source of truth, and just because you are filtering the view, does not mean the folder's contents have changed.

In my opinion, the Details Pane data should reflect what the user actually sees. This behavior is consistent with Microsoft Windows Explorer.

[yaira2]

Just so I am clear, the Details Pane will always show the total file and folder count, even with a filtered view right?

@mdtauk after this PR, yes.

Where as the status bar can show a count for the current view, be it filtered or not filtered?

Please see #17289.