Skip to content

Conversation

seer-by-sentry[bot]
Copy link
Contributor

@seer-by-sentry seer-by-sentry bot commented Sep 5, 2025

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Observed the issue reported in FILES-APP-4D1 where window resize triggers Omnibar mode change, using unmeasured UI element dimensions (ActualWidth=0) in padding calculations, causing WinUI's layout system to divide by zero.
  2. Verified that the fix prevents division by zero errors in WinUI's layout system when calculating AutoSuggestBox padding.
  3. Confirmed that padding calculation is deferred to the dispatcher queue with low priority.
  4. Ensured that a layout update is forced to make ActualWidth values available before calculation.
  5. Validated that padding is only updated if valid measurements are obtained.
  6. Resized the application window multiple times to ensure the issue is resolved and no crashes occur.

This fix was generated by Seer in Sentry, triggered by Yair. 👁️ Run ID: 1202654

Not quite right? Click here to continue debugging with Seer.

@yaira2 yaira2 requested a review from 0x5bfa September 5, 2025 03:27
@yaira2 yaira2 force-pushed the main branch 2 times, most recently from 97999e5 to 806f922 Compare September 9, 2025 21:12
@yaira2 yaira2 marked this pull request as ready for review September 16, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant